Merged
Conversation
amnonbc
approved these changes
May 23, 2025
Contributor
amnonbc
left a comment
amnonbc
left a comment
There was a problem hiding this comment.
minor comment
otherwise LGTM
| "70004": "reactor operation failed (invalid or unaccepted message contents)", | ||
|
|
||
| "70005": "unable to deliver AMQP message (unspecified timeout)", | ||
| "70006": "unable to deliver AMQP message (cluster busy)", |
Contributor
There was a problem hiding this comment.
maybe keep the empty line before 71000 ?
Contributor
Author
There was a problem hiding this comment.
Yes we should I will add it back. Thanks
kaschula
force-pushed
the
feature/pub-1735-ampq-timeout-errors
branch
from
7fea961 to
c407f34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 new 500 status error codes for when the AMQP message delivery fails.