Skip to content

Only enable dynamic exhibit delay while typing #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basil-conto merged 2 commits into from
Apr 16, 2025
Merged

Only enable dynamic exhibit delay while typing #2941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9cdd22
Only enable dynamic exhibit delay while typing
Gleek Dec 18, 2021
fd8df3b
Clean up ivy--queue-exhibit
basil-conto Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions ivy.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3409,25 +3409,29 @@ Otherwise, ~/ will move home."
:type 'boolean)

(defcustom ivy-dynamic-exhibit-delay-ms 0
"Delay in ms before dynamic collections are refreshed"
"Delay in milliseconds before dynamic collections are refreshed."
:type 'integer)

(defvar ivy--exhibit-timer nil)
(defvar ivy--exhibit-timer nil
"Timer for debouncing calls to `ivy--exhibit'.")

(defvar ivy--queue-last-input nil
"Value of `ivy--input' from last `post-command-hook'.")

(defun ivy--queue-exhibit ()
"Insert Ivy completions display, possibly after a timeout for
dynamic collections.
"Refresh Ivy completions display, with debouncing.
This is like `ivy--exhibit', but dynamic collections are delayed by
`ivy-dynamic-exhibit-delay-ms' to avoid issues with rapid refreshes.
Should be run via minibuffer `post-command-hook'."
(if (and (> ivy-dynamic-exhibit-delay-ms 0)
(ivy-state-dynamic-collection ivy-last))
(progn
(when ivy--exhibit-timer (cancel-timer ivy--exhibit-timer))
(setq ivy--exhibit-timer
(run-with-timer
(/ ivy-dynamic-exhibit-delay-ms 1000.0)
nil
'ivy--exhibit)))
(ivy--exhibit)))
(if (or (<= ivy-dynamic-exhibit-delay-ms 0)
(not (ivy-state-dynamic-collection ivy-last))
(equal ivy--queue-last-input
(setq ivy--queue-last-input (ivy--input))))
(ivy--exhibit)
(when ivy--exhibit-timer (cancel-timer ivy--exhibit-timer))
(setq ivy--exhibit-timer
(run-with-timer (/ ivy-dynamic-exhibit-delay-ms 1000.0)
nil #'ivy--exhibit))))

(defalias 'ivy--file-local-name
(if (fboundp 'file-local-name)
Expand Down Expand Up @@ -3455,8 +3459,8 @@ The function was added in Emacs 26.1.")

(defun ivy--exhibit ()
"Insert Ivy completions display.
Should be run via minibuffer `post-command-hook'."
(when (memq 'ivy--queue-exhibit post-command-hook)
Should be run in the minibuffer."
(when (memq #'ivy--queue-exhibit post-command-hook)
(let ((inhibit-field-text-motion nil))
(constrain-to-field nil (point-max)))
(ivy-set-text (ivy--input))
Expand Down