deps: Nethermind 1.37.1 + Autofac 9.1.0 + Int256 1.5.0 (Wave 2 atomic bundle) - #359
Conversation
…+ Int256 1.3.6 → 1.5.0 Atomic dependency bundle. Autofac bump is required: Nethermind 1.37.1's Nethermind.Api references Autofac 9.1.0; the 9.0.0 → 9.1.0 mismatch otherwise produces CS1705 at link time. - Nethermind.ReferenceAssemblies 1.36.2 → 1.37.1 (4 csproj) - Nethermind.Numerics.Int256 1.3.6 → 1.5.0 (11 csproj) - Autofac 9.0.0 → 9.1.0 (3 csproj) - nethermind/nethermind base image 1.36.2 → 1.37.1 (Index.Dockerfile) Plugin's API surface into Nethermind (BlockTree.Head, NewHeadBlock event, SyncModeSelector.Current, IBlockTree.FindBlock, IReceiptFinder.Get) was audited and compiles + tests cleanly against 1.37.1's worldstate refactor. Supersedes #251, #351, #352.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary
Nethermind.ReferenceAssemblies1.36.2 → 1.37.1Nethermind.Numerics.Int2561.3.6 → 1.5.0Autofac9.0.0 → 9.1.0 (required: Nethermind 1.37.1'sNethermind.Apireferences Autofac 9.1.0; mismatch produces CS1705 at link time)nethermind/nethermindDocker base image 1.36.2 → 1.37.1 (docker/Index.Dockerfile)Atomic bundle — all four bumps must land together. Supersedes #251, #351, #352.
Audit
Plugin's surface into Nethermind APIs (
IBlockTree.Head,NewHeadBlockevent,SyncModeSelector.Current,IBlockTree.FindBlock,IReceiptFinder.Get) was reviewed against 1.37.1's worldstate refactor. All call sites compile against 1.37.1 and tests pass with no regression.No Vault, NDM, eth/66, eth/67,
EngineApiVersion,IsMining, orStoreReceiptsreferences — plugin is event-indexer only, unaffected by 1.37.1's protocol/Engine API changes.Local results:
dotnet build -c Release— 0 errors, 143 warnings (all pre-existing categories: internalSettings.DisableConsentedFlowdeprecation warnings introduced in fix(pathfinder): unconditional consented sender->Group rejection #345/fix(pathfinder): close consented-source -> non-Group leak + enforce audit safety net #346/fix(pathfinder): post-merge review followups (validator + historical + tests) #358, plus the documentedNewtonsoft.JsonCVE andNU1510pruning notes)./scripts/test.sh— 1219 passed, 0 failed, 390 skipped (staging-/Anvil-dependent)Test plan
./scripts/test-rpc.shagainst staging URL — allcircles_*200 OKnethermindlogs show noEngineApiVersionmismatch with the consensus client