Add config options for Redis connection (TLS, username, DB) #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification allows to establish a secure connection to an external Redis instance in scenarios where PurlDB is not deployed via docker compose. The current defaults are kept for compatibility reasons. This means by default no TLS is used, as is currently already the case, as a local deployment with docker compose assumed where all services are runing on the same host. Similar fixes have been made in DejaCode (aboutcode-org/dejacode@1a4f703) and ScanCode.io (aboutcode-org/scancode.io@f0750d4). Signed-off-by: Robert Guetzkow <[email protected]>
Member
|
Thanks! @JonoYang ping :) |
Member
|
@rogu-beta BTW, I am always wondering if we really need the baggage of Redis... and if using the DB as a queue would not be plenty enough. |
Author
|
@pombredanne That is certainly an option. It's difficult to judge such architectural choices as merely a contributor. Removing Redis as a dependency may simplify some aspects, but it would require the introduction of new abstractions and likely additional libraries to make PostgreSQL work as job queue. Performance impact may also be a concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification allows to establish a secure connection to an external Redis instance in scenarios where PurlDB is not deployed via docker compose. The current defaults are kept for compatibility reasons. This means by default no TLS is used, as is currently already the case, as a local deployment with docker compose is assumed where all services are runing on the same host. Similar fixes have been made in DejaCode (aboutcode-org/dejacode@1a4f703) and ScanCode.io (aboutcode-org/scancode.io@f0750d4).