Add Lua rockspec package handler for LuaRocks dependencies by SLASH217 · Pull Request #4743 · aboutcode-org/scancode-toolkit

SLASH217 · 2026-02-13T16:29:35Z

Add Lua rockspec package handler for LuaRocks dependencies

Changes

Added RockspecHandler class for .rockspec file detection
Implemented RockspecParser using Lua AST parsing with luaparser library
Extracts package metadata: name, version, description, license, homepage_url, vcs_url (non-exhaustive list)
Integrated handler into APPLICATION_PACKAGE_DATAFILE_HANDLERS registry
Added 23 comprehensive unit and integration tests
Fixed dead documentation links in CONTRIBUTING.rst

Tasks

Reviewed contribution guidelines
PR is descriptively titled 📑 and links the original issue above 🔗
Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
Run tests locally to check for errors.
Commits are in uniquely-named feature branch and has no merge conflicts 📁
Updated documentation pages (if applicable)
Updated CHANGELOG.rst (if applicable)

Signed-off-by: Prashanna Dahal prashanna217@gmail.com

Implement base handler class and Lua rockspec parser using luaparser for AST-based dependency extraction. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Extract package metadata and dependencies from rockspec files with version specification parsing. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

* Test parser with real Kong rockspec file * Test handler integration with patterns Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Register handler in APPLICATION_PACKAGE_DATAFILE_HANDLERS to enable automatic .rockspec file detection. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

* Update contributing-docs link to new structure * Ensure both documentation links work correctly * Point to getting-started/contribute path Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Change luaparser from == to match project's version pinning pattern: * requirements.txt: luaparser==1.4.3 (exact pinning) * setup.cfg: luaparser == 1.4.3 (exact pinning) Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

- This was causing a test to fail in CI/CD Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

- Extra "/n" causing failure of CI/CD Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

AyanSinhaMahapatra

Thanks++ @SLASH217 for the PR, looking good already, but you need to modify the tests so we can see the full output and verify the functionality added before I can do an in depth review. Added some other feedback you also need to address.

AyanSinhaMahapatra · 2026-02-18T09:47:46Z

tests/packagedcode/test_rockspec.py

+        parser = rockspec.RockspecParser(test_file)
+        data = parser.parse()
+
+        assert data['rockspec_format'] == '3.0'


This is not how we write tests for package manifest parsers, asserting the data one by one. Instead we dump the whole results in a JSON file and check the output matches to it, so we can see the entire output and test it, and not just some fields. And this result is more readable, and for changes we can regen and check the changes in output.
This is done using tests.packagedcode.packages_test_utils.Packagetester.check_packages_data()

See how this is done in all other test files for package manifest parsers, for example:

scancode-toolkit/tests/packagedcode/test_pypi.py

Line 163 in 022ddc8

self.check_packages_data(package, expected_loc, regen=REGEN_TEST_FIXTURES)

AyanSinhaMahapatra · 2026-02-18T09:49:41Z

tests/packagedcode/data/rockspec/test1.rockspec

+build = {
+  type = "builtin",
+  modules = {
+    ["kong"] = "kong/init.lua",


AFAIK we are not parsing/storing the modules info here and this is increasing the test file size without contributing anything to the test, can you remove these modules from all the tests?

Same for all non essential things in other test files.

I have removed the unnecessary bloat from the test files.

AyanSinhaMahapatra · 2026-02-18T09:50:37Z

tests/packagedcode/data/rockspec/test1.rockspec

@@ -0,0 +1,530 @@
+package = "kong"


Would be great to add the link to this test file (and all others) as a comment, since these are real files(?) and we should provide where we got them from

Added the source of the rockspec files in test_file_source.txt.

AyanSinhaMahapatra · 2026-02-18T10:07:05Z

src/packagedcode/rockspec.py

+            - name: Package name
+            - version_number: Clean version number (e.g. "3.1.3") or None
+            - version_spec: Full version specification with operator (e.g. "== 3.1.3") or None
+            - raw: Original input string


Not sure why you want to pass back the input, don't we already have this in context?

AyanSinhaMahapatra · 2026-02-18T10:08:49Z

src/packagedcode/rockspec.py

+            package_name: Name of the package
+            package_version: Optional version string (without operators)
+
+        Returns:


This is additional information you're conveying twice, and not how we write the docstrings. Just describe the output, what it does and the inputs in a short to-the-point docstring. For all the functions

AyanSinhaMahapatra · 2026-02-18T10:10:05Z

src/packagedcode/rockspec.py

+            extra_data['supported_platforms'] = platforms
+
+        # Future fields can be added here
+        # e.g., build_backend, build_requires, etc.


Why not just add these now? And if you're keeping work for later, add a TODO:

AyanSinhaMahapatra · 2026-02-18T10:12:38Z

setup.cfg

    jsonstreams >= 0.5.0
    license_expression >= 30.4.4
    lxml >= 5.4.0
+    luaparser == 4.0.0


Let's not pin dependencies, you can add this as a lower bound. We are a library too :)

Understood! Will keep in mind for future commits.

AyanSinhaMahapatra · 2026-02-18T10:26:23Z

requirements.txt

 keyring==23.7.0
 license-expression==30.4.4
 lxml==6.0.2
+luaparser==4.0.0


This is also installing two new dependencies, can you also add these here?
https://github.com/boolangery/py-lua-parser/blob/master/setup.py#L29

I have added the two transitive dependencies.
multimethod in particular didn't have any explicit version in the luaparser repo.
So i have pinned it to multimethod==2.0.2 for the requirements.txt file.
Since this is the version that gets installed.

CONTRIBUTING.rst

SLASH217 · 2026-02-19T17:19:49Z

Thank you for your feedback and valuable time.
I will diligently make the updates and push as soon as possible.

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

-- Added links for source of .rockspec files used in testing. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

-- Modules not required to be parsed Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

-- updated to be lower bound Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

-- use check_packages_data -- instead of manually asserting data one by one. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

-- Causing the CI/CD to fail. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Prashanna Dahal added 5 commits February 13, 2026 14:04

Add RockspecHandler base and parser

f9324f8

Implement base handler class and Lua rockspec parser using luaparser for AST-based dependency extraction. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Implement parser logic in handler

af15759

Extract package metadata and dependencies from rockspec files with version specification parsing. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Add unit tests for RockspecHandler

d106e92

* Test parser with real Kong rockspec file * Test handler integration with patterns Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Integrate RockspecHandler into __init__

dc4fc99

Register handler in APPLICATION_PACKAGE_DATAFILE_HANDLERS to enable automatic .rockspec file detection. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix dead documentation links

99cd99f

* Update contributing-docs link to new structure * Ensure both documentation links work correctly * Point to getting-started/contribute path Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

SLASH217 force-pushed the support_rockspec branch from 35fb9e2 to c84c872 Compare February 13, 2026 16:49

Fix luaparser version specifier aboutcode-org#3526

3b359de

Change luaparser from == to match project's version pinning pattern: * requirements.txt: luaparser==1.4.3 (exact pinning) * setup.cfg: luaparser == 1.4.3 (exact pinning) Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

SLASH217 force-pushed the support_rockspec branch from c84c872 to 3b359de Compare February 13, 2026 16:57

Prashanna Dahal added 3 commits February 14, 2026 17:47

Add LuaRocks rockspec package handler to plugins list.

9a0cd5f

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix auto-formatter changes in .txt file

4103a81

- This was causing a test to fail in CI/CD Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix auto-formatter changes in .txt file

d7b5fbd

- Extra "/n" causing failure of CI/CD Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

prabhu mentioned this pull request Feb 15, 2026

[lua] luarocks support cdxgen/cdxgen#3485

Open

AyanSinhaMahapatra requested changes Feb 18, 2026

View reviewed changes

AyanSinhaMahapatra reviewed Feb 18, 2026

View reviewed changes

CONTRIBUTING.rst Show resolved Hide resolved

AyanSinhaMahapatra added the need-changes PR needs to be updated with feedback label Feb 18, 2026

SLASH217 force-pushed the support_rockspec branch 3 times, most recently from 8bf9473 to 707adbc Compare February 20, 2026 21:06

Prashanna Dahal added 2 commits February 21, 2026 02:40

Fix updated docstrings to be clear and concise.

0dad109

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Add todo for parsing build table.

7a5e0ba

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

SLASH217 force-pushed the support_rockspec branch from 707adbc to 127f3fc Compare February 20, 2026 21:10

Prashanna Dahal added 6 commits February 21, 2026 02:43

Add test file source links.

9463a8b

-- Added links for source of .rockspec files used in testing. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix remove unparsed modules from test files

d7eef6c

-- Modules not required to be parsed Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Add transitive dependencies of luaparser

d8a00e5

Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix unpin luaparser dependency

0d11d04

-- updated to be lower bound Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix tests to follow scancode format

f2eb2d7

-- use check_packages_data -- instead of manually asserting data one by one. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

Fix auto-formatter changes in .txt file

21ca2ff

-- Causing the CI/CD to fail. Signed-off-by: Prashanna Dahal <prashanna217@gmail.com>

SLASH217 force-pushed the support_rockspec branch from 127f3fc to 21ca2ff Compare February 20, 2026 21:13

Uh oh!

Comments

Conversation

SLASH217 commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!