Fix invalid SPDX expressions for license exceptions to use WITH operator#4762
Open
dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
Open
Fix invalid SPDX expressions for license exceptions to use WITH operator#4762dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
Fixes aboutcode-org#4623 Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4623
Description
ScanCode was generating invalid SPDX license expressions when combining licenses with their exceptions. According to SPDX specification, exceptions must be combined with licenses using the
WITHoperator, notAND.Before:
After:
Changes
combine_expressions_with_exception_handling()function to detect when a license is paired with an exception and combine them usingWITHinstead ofANDget_detected_license_expression()to use the new functiontest_gpl_with_gcc_exception_uses_with_operator()to verify the fixTesting
Tasks