Refine D2D pipeline for Scala and Kotlin#1895
Conversation
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
There was a problem hiding this comment.
@TG1999 LGTM! Thanks
See comments with a few nits for your consideration, looks good to merge otherwise.
One thing to note is #1404 was for: binary to source analysis for Java using strings and symbols. for java and other JVM languages, which needs source symbol extraction on source-inspector, binary symbol extraction from some of these cases, covering XML/JAXB type java generated code.
But this PR adds source to binary mapping using path matching and a bit more for scala and kotlin, which are tracked in:
which are subtasks for #1404 and not the whole issue.
There is also:
which are not addressed yet if I understand correctly, if these are addressed we need tests for these to close them. I am fine to reduce the scope of #1404 for this project and have these as later enhancements, but we need to explain this clearly in the PR as this PR closing the entirety of:
is not correct as the task in the issue is currently stated differently.
2 participants
closes: #1404