Skip to content

Multi-Tenant Account Usage: Shared user accounts - #24456

Merged
ismcagdas merged 25 commits into
devfrom
Shared-User-Account
Feb 16, 2026
Merged

Multi-Tenant Account Usage: Shared user accounts#24456
ismcagdas merged 25 commits into
devfrom
Shared-User-Account

Conversation

@maliming

@maliming maliming commented Dec 21, 2025

Copy link
Copy Markdown
Member

@maliming
maliming force-pushed the Shared-User-Account branch from 4e8a462 to 4b77de5 Compare December 23, 2025 06:30
@maliming maliming added this to the 10.1-preview milestone Dec 24, 2025
@maliming
maliming marked this pull request as ready for review December 29, 2025 04:40
Copilot AI review requested due to automatic review settings December 29, 2025 04:40

This comment was marked as outdated.

@codecov

codecov Bot commented Dec 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.26504% with 365 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.92%. Comparing base (c805596) to head (594b0bb).
⚠️ Report is 207 commits behind head on dev.

Files with missing lines Patch % Lines
...olo.Abp.Data/Volo/Abp/Data/DataFilterExtensions.cs 0.00% 154 Missing ⚠️
...sts/Volo/Abp/Identity/IdentityUserManager_Tests.cs 0.00% 98 Missing ⚠️
...ty.Domain/Volo/Abp/Identity/IdentityUserManager.cs 65.00% 27 Missing and 8 partials ⚠️
...e/Volo/Abp/Identity/AspNetCore/AbpSignInManager.cs 26.92% 18 Missing and 1 partial ⚠️
...lo/Abp/Identity/AbpIdentityErrorDescriber_Tests.cs 0.00% 18 Missing ⚠️
....Identity.Domain/Volo/Abp/Identity/IdentityUser.cs 6.66% 14 Missing ⚠️
...main/Volo/Abp/Identity/AbpIdentityUserValidator.cs 87.91% 8 Missing and 3 partials ⚠️
...GlobalFilters/AbpCompiledQueryCacheKeyGenerator.cs 42.85% 7 Missing and 1 partial ⚠️
...olo/Abp/Identity/IdentityUserPasswordChangedEto.cs 0.00% 3 Missing ⚠️
...s/Volo/Abp/Users/InviteUserToTenantRequestedEto.cs 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #24456      +/-   ##
==========================================
- Coverage   50.99%   50.92%   -0.08%     
==========================================
  Files        3379     3384       +5     
  Lines      110904   112033    +1129     
  Branches     8449     8483      +34     
==========================================
+ Hits        56555    57049     +494     
- Misses      52605    53239     +634     
- Partials     1744     1745       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming
maliming requested a review from hikalkan December 29, 2025 07:26
@maliming
maliming force-pushed the Shared-User-Account branch from d335aeb to f21ffe2 Compare December 29, 2025 07:43
@skoc10 skoc10 modified the milestones: 10.1-preview, 10.1-final Dec 30, 2025
@hikalkan hikalkan modified the milestones: 10.1-final, 10.2-preview Dec 30, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 76.2%, saving 2.6 MB.

Filename Before After Improvement Visual comparison
docs/en/images/tenant-selection.png 485.9 KB 120.8 KB 75.1% View diff
docs/en/images/new-user-accept.png 412.2 KB 97.6 KB 76.3% View diff
docs/en/images/new-user-join-strategy-inform.png 386.5 KB 93.6 KB 75.8% View diff
docs/en/images/new-user-join-strategy-create-tenant.png 387.5 KB 94.9 KB 75.5% View diff
docs/en/images/user-accepted.png 387.8 KB 97.6 KB 74.8% View diff
docs/en/images/new-user-join-strategy-create-tenant-success.png 386.0 KB 96.2 KB 75.1% View diff
docs/en/images/exist-user-accept.png 364.9 KB 85.6 KB 76.5% View diff
docs/en/images/switch-tenant.png 218.1 KB 48.6 KB 77.7% View diff
docs/en/images/invite-user.png 170.8 KB 35.6 KB 79.1% View diff
docs/en/images/manage-invitations.png 145.4 KB 30.9 KB 78.8% View diff
docs/en/images/invite-admin-user-to-join-tenant.png 75.5 KB 15.9 KB 78.9% View diff
docs/en/images/invite-admin-user-to-join-tenant-modal.png 60.8 KB 12.6 KB 79.3% View diff

@github-actions

Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 8.1%, saving 14.4 KB.

Filename Before After Improvement Visual comparison
docs/en/images/invite-user.png 35.6 KB 29.6 KB 16.9% View diff
docs/en/images/new-user-join-strategy-create-tenant-success.png 96.2 KB 91.3 KB 5.1% View diff
docs/en/images/manage-invitations.png 30.9 KB 28.4 KB 8.0% View diff
docs/en/images/invite-admin-user-to-join-tenant.png 15.9 KB 14.9 KB 6.2% View diff

8 images did not require optimisation.

@github-actions

Copy link
Copy Markdown
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 13.5%, saving 3.8 KB.

Filename Before After Improvement Visual comparison
docs/en/images/manage-invitations.png 28.4 KB 24.6 KB 13.5% View diff

11 images did not require optimisation.

@ismcagdas
ismcagdas merged commit 1ff6a73 into dev Feb 16, 2026
1 check passed
@ismcagdas
ismcagdas deleted the Shared-User-Account branch February 16, 2026 12:08
return await SignInOrTwoFactorAsync(user, isPersistent, loginProvider, bypassTwoFactor);
}

public virtual async Task<IdentityUser> FindByEmaiAsync(string email)

This comment was marked as resolved.

@maliming
maliming restored the Shared-User-Account branch April 17, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants