Skip to content

Migrate ABP Angular templates to Vitest as the default testing framework - Issue 24714 #24725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fahrigedik merged 5 commits into from
Feb 17, 2026
Merged

Migrate ABP Angular templates to Vitest as the default testing framework - Issue 24714 #24725

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a2dee7
Migrate Angular tests from Karma/Jasmine to Vitest
fahrigedik Jan 23, 2026
36435bd
Migrate Angular template from Karma/Jasmine to Vitest on app-no-layers
fahrigedik Jan 23, 2026
4d537d6
Migrate Angular template from Karma/Jasmine to Vitest
fahrigedik Jan 23, 2026
b2cbc15
Refactor HomeComponent tests and update vitest version
fahrigedik Jan 29, 2026
2bf1c51
Merge branch 'dev' into issue-24714
fahrigedik Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions templates/app-nolayers/angular/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,17 +163,7 @@
}
},
"test": {
"builder": "@angular/build:karma",
"options": {
"browser": "src/test.ts",
"polyfills": ["src/polyfills.ts"],
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"inlineStyleLanguage": "scss",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss"],
"scripts": []
}
"builder": "@angular/build:unit-test"
},
"lint": {
"builder": "@angular-eslint/builder:lint",
Expand Down
44 changes: 0 additions & 44 deletions templates/app-nolayers/angular/karma.conf.js
View file
Open in desktop

This file was deleted.

11 changes: 3 additions & 8 deletions templates/app-nolayers/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,12 @@
"@angular/cli": "~21.0.0",
"@angular/compiler-cli": "~21.0.0",
"@angular/language-service": "~21.0.0",
"@types/jasmine": "~3.6.0",
"@types/node": "^12.11.1",
"@typescript-eslint/eslint-plugin": "7.16.0",
"@typescript-eslint/parser": "7.16.0",
"eslint": "^8.0.0",
"jasmine-core": "~4.0.0",
"karma": "~6.4.4",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.1.0",
"karma-jasmine": "~4.0.0",
"karma-jasmine-html-reporter": "^1.7.0",
"typescript": "~5.9.0"
"jsdom": "^27.1.0",
"typescript": "~5.9.0",
"vitest": "^4.0.8"
}
}
24 changes: 15 additions & 9 deletions templates/app-nolayers/angular/src/app/home/home.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
import { CoreTestingModule } from '@abp/ng.core/testing';
import { ThemeSharedTestingModule } from '@abp/ng.theme.shared/testing';
import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { NgxValidateCoreModule } from '@ngx-validate/core';
import { HomeComponent } from './home.component';
import { OAuthService } from 'angular-oauth2-oidc';
import { AuthService } from '@abp/ng.core';
import { vi } from 'vitest';

describe('HomeComponent', () => {
let fixture: ComponentFixture<HomeComponent>;
const mockOAuthService = jasmine.createSpyObj('OAuthService', ['hasValidAccessToken']);
const mockAuthService = jasmine.createSpyObj('AuthService', ['navigateToLogin']);
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
declarations: [HomeComponent],
const mockOAuthService = {
hasValidAccessToken: vi.fn(),
};
const mockAuthService = {
navigateToLogin: vi.fn(),
};

beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [
CoreTestingModule.withConfig(),
ThemeSharedTestingModule.withConfig(),
NgxValidateCoreModule,
HomeComponent,
],
providers: [
/* mock providers here */
Expand All @@ -30,7 +36,7 @@ describe('HomeComponent', () => {
},
],
}).compileComponents();
}));
});

beforeEach(() => {
fixture = TestBed.createComponent(HomeComponent);
Expand All @@ -43,11 +49,11 @@ describe('HomeComponent', () => {

describe('when login state is true', () => {
beforeAll(() => {
mockOAuthService.hasValidAccessToken.and.returnValue(true);
mockOAuthService.hasValidAccessToken.mockReturnValue(true);
});

it('hasLoggedIn should be true', () => {
expect(fixture.componentInstance.hasLoggedIn).toBeTrue();
expect(fixture.componentInstance.hasLoggedIn).toBe(true);
expect(mockOAuthService.hasValidAccessToken).toHaveBeenCalled();
});

Expand Down
13 changes: 0 additions & 13 deletions templates/app-nolayers/angular/src/test.ts
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions templates/app-nolayers/angular/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html. */
/* To learn more about Angular compiler options: https://angular.dev/reference/configs/angular-compiler-options. */
{
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "./out-tsc/app",
"types": []
},
"files": [
"src/main.ts",
"src/polyfills.ts"
],
"include": [
"src/**/*.d.ts"
"src/**/*.ts"
],
"exclude": [
"src/**/*.spec.ts"
]
}
13 changes: 5 additions & 8 deletions templates/app-nolayers/angular/tsconfig.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
/* To learn more about this file see: https://angular.io/config/tsconfig. */
/* To learn more about Typescript configuration file: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html. */
/* To learn more about Angular compiler options: https://angular.dev/reference/configs/angular-compiler-options. */
{
"extends": "./tsconfig.json",
"compilerOptions": {
"outDir": "./out-tsc/spec",
"types": [
"jasmine"
"vitest/globals"
]
},
"files": [
"src/test.ts",
"src/polyfills.ts"
],
"include": [
"src/**/*.spec.ts",
"src/**/*.d.ts"
"src/**/*.d.ts",
"src/**/*.spec.ts"
]
}
12 changes: 1 addition & 11 deletions templates/app/angular/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,17 +163,7 @@
}
},
"test": {
"builder": "@angular/build:karma",
"options": {
"browser": "src/test.ts",
"polyfills": ["src/polyfills.ts"],
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"inlineStyleLanguage": "scss",
"assets": ["src/favicon.ico", "src/assets"],
"styles": ["src/styles.scss"],
"scripts": []
}
"builder": "@angular/build:unit-test"
},
"lint": {
"builder": "@angular-eslint/builder:lint",
Expand Down
44 changes: 0 additions & 44 deletions templates/app/angular/karma.conf.js
View file
Open in desktop

This file was deleted.

11 changes: 3 additions & 8 deletions templates/app/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,12 @@
"@angular/cli": "~21.0.0",
"@angular/compiler-cli": "~21.0.0",
"@angular/language-service": "~21.0.0",
"@types/jasmine": "~3.6.0",
"@types/node": "~20.11.0",
"@typescript-eslint/eslint-plugin": "7.16.0",
"@typescript-eslint/parser": "7.16.0",
"eslint": "^8.0.0",
"jasmine-core": "~4.0.0",
"karma": "~6.4.4",
"karma-chrome-launcher": "~3.1.0",
"karma-coverage": "~2.1.0",
"karma-jasmine": "~4.0.0",
"karma-jasmine-html-reporter": "^1.7.0",
"typescript": "~5.9.3"
"jsdom": "^27.1.0",
"typescript": "~5.9.3",
"vitest": "^4.0.8"
}
}
1 change: 0 additions & 1 deletion templates/app/angular/src/app/home/home.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<div class="row mb-3">

Copilot AI Jan 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains unrelated changes to the home component HTML template that are not part of the Vitest migration. The removal of the abp-dynamic-form element is unrelated to the testing framework migration. According to the PR description, this PR should be "intentionally scoped only to the Vitest migration."

This change should be removed from this PR or moved to a separate PR.

Copilot uses AI. Check for mistakes.
<abp-dynamic-form [fields]="formFields" />
<div class="col-xl-6 col-12 d-flex">
<div class="card h-lg-100 w-100 overflow-hidden">
<div class="card-body">
Expand Down
Loading
Loading