fix: initialize ProfileManagementPageCreationContext in OnPostAsync of ManageModel#25067
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Account “Manage” Razor Page model so that POST requests rebuild the ProfileManagementPageCreationContext and run all configured ProfileManagementPageOptions.Contributors, matching the GET behavior and ensuring the page can render correctly after a POST.
Changes:
- Make
OnPostAsyncasynchronous. - Initialize
ProfileManagementPageCreationContexton POST and run contributors viaConfigureAsync.
yagmurcelk
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ManageModel.OnPostAsyncreturnedPage()without initializingProfileManagementPageCreationContext, causing aNullReferenceExceptionwhen the view tried to renderModel.ProfileManagementPageCreationContext.Groupsinside the<abp-tabs>tag helper.Although normal usage relies on JavaScript to intercept form submissions (using AJAX instead of a native HTML POST), a direct POST to
/Account/Manage— triggered by JS being disabled, a JS load failure, or an automated tool — would hitOnPostAsyncand crash during view rendering.The fix mirrors the initialization logic from
OnGetAsync: creating a newProfileManagementPageCreationContextand running all registered contributors through it before returningPage().