Remove malihu-custom-scrollbar-plugin and use native scrollbars - #26000
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated malihu-custom-scrollbar-plugin integration from ABP’s MVC UI packages and updates Docs, Feature Management, and Permission Management UIs to rely on native browser scrolling (with light CSS scrollbar styling where needed), aligning with #25967.
Changes:
- Removes the
@abp/malihu-custom-scrollbar-pluginnpm pack and the corresponding ASP.NET Core bundle contributors. - Drops Malihu initialization code from Docs / Feature Management / Permission Management scripts and adjusts selectors that previously depended on Malihu’s DOM wrappers.
- Adds/updates CSS to enable native scrolling and (Firefox-focused) thin scrollbar styling in affected areas.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| npm/packs/malihu-custom-scrollbar-plugin/README.md | Deletes the deprecated npm pack documentation. |
| npm/packs/malihu-custom-scrollbar-plugin/package.json | Removes the deprecated @abp/malihu-custom-scrollbar-plugin pack definition. |
| npm/packs/malihu-custom-scrollbar-plugin/abp.resourcemapping.js | Removes Malihu resource mapping for bundling. |
| npm/packs/docs/package.json | Drops @abp/malihu-custom-scrollbar-plugin dependency from docs pack. |
| npm/packs/aspnetcore.mvc.ui.theme.shared/package.json | Drops @abp/malihu-custom-scrollbar-plugin dependency from shared theme pack. |
| modules/permission-management/src/Volo.Abp.PermissionManagement.Web/Pages/AbpPermissionManagement/permission-management-modal.js | Removes Malihu scrollbar initialization from permission management modal. |
| modules/feature-management/src/Volo.Abp.FeatureManagement.Web/Pages/FeatureManagement/feature-management-modal.js | Removes Malihu scrollbar initialization from feature management modal. |
| modules/feature-management/src/Volo.Abp.FeatureManagement.Web/Pages/FeatureManagement/feature-management-modal.css | Enables native scrolling and thin scrollbars for feature management modal sections. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.scss | Removes Malihu-specific styling and adds native scrollbar styling for docs UI elements. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css | Updates generated CSS to match vs.scss changes. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css.map | Updates generated source map to match rebuilt CSS output. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Scripts/vs.js | Removes Malihu initialization/resizing hooks from docs scripts. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/index.js | Removes selectors that depended on Malihu-generated .mCSB_container wrappers. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/Index.cshtml | Removes Malihu bundle contributor usage and Malihu-specific CSS class usage in markup. |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Bundling/SharedThemeGlobalStyleContributor.cs | Removes Malihu style contributor dependency from shared theme global styles. |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Bundling/SharedThemeGlobalScriptContributor.cs | Removes Malihu script contributor dependency from shared theme global scripts. |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/MalihuCustomScrollbar/MalihuCustomScrollbarPluginStyleBundleContributor.cs | Deletes Malihu style bundle contributor implementation. |
| framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/MalihuCustomScrollbar/MalihuCustomScrollbarPluginScriptBundleContributor.cs | Deletes Malihu script bundle contributor implementation. |
| docs/en/framework/ui/mvc-razor-pages/theming.md | Removes Malihu mention from theming docs. |
| docs/en/framework/ui/mvc-razor-pages/overall.md | Removes Malihu mention from overall MVC UI docs. |
Files not reviewed (1)
- modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #26000 +/- ##
==========================================
- Coverage 48.99% 48.97% -0.02%
==========================================
Files 3805 3813 +8
Lines 132259 132478 +219
Branches 10027 10038 +11
==========================================
+ Hits 64796 64879 +83
- Misses 65536 65666 +130
- Partials 1927 1933 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Resolve #25967
Removes the
MalihuCustomScrollbarPlugin*BundleContributorclasses and the@abp/malihu-custom-scrollbar-pluginpackage; the docs, feature management and permission management pages scroll natively.