Skip to content

Remove malihu-custom-scrollbar-plugin and use native scrollbars - #26000

Merged
maliming merged 2 commits into
devfrom
maliming/remove-malihu-scrollbar
Aug 21, 2026
Merged

Remove malihu-custom-scrollbar-plugin and use native scrollbars#26000
maliming merged 2 commits into
devfrom
maliming/remove-malihu-scrollbar

Conversation

@maliming

Copy link
Copy Markdown
Member

Resolve #25967

Removes the MalihuCustomScrollbarPlugin*BundleContributor classes and the @abp/malihu-custom-scrollbar-plugin package; the docs, feature management and permission management pages scroll natively.

@maliming maliming added this to the 10.8-preview milestone Aug 18, 2026
@maliming
maliming requested a review from EngincanV August 21, 2026 01:52
@maliming
maliming marked this pull request as ready for review August 21, 2026 07:36
Copilot AI lite review requested due to automatic review settings August 21, 2026 07:36
@maliming
maliming merged commit c551f8a into dev Aug 21, 2026
4 checks passed
@maliming
maliming deleted the maliming/remove-malihu-scrollbar branch August 21, 2026 07:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated malihu-custom-scrollbar-plugin integration from ABP’s MVC UI packages and updates Docs, Feature Management, and Permission Management UIs to rely on native browser scrolling (with light CSS scrollbar styling where needed), aligning with #25967.

Changes:

  • Removes the @abp/malihu-custom-scrollbar-plugin npm pack and the corresponding ASP.NET Core bundle contributors.
  • Drops Malihu initialization code from Docs / Feature Management / Permission Management scripts and adjusts selectors that previously depended on Malihu’s DOM wrappers.
  • Adds/updates CSS to enable native scrolling and (Firefox-focused) thin scrollbar styling in affected areas.

Reviewed changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
npm/packs/malihu-custom-scrollbar-plugin/README.md Deletes the deprecated npm pack documentation.
npm/packs/malihu-custom-scrollbar-plugin/package.json Removes the deprecated @abp/malihu-custom-scrollbar-plugin pack definition.
npm/packs/malihu-custom-scrollbar-plugin/abp.resourcemapping.js Removes Malihu resource mapping for bundling.
npm/packs/docs/package.json Drops @abp/malihu-custom-scrollbar-plugin dependency from docs pack.
npm/packs/aspnetcore.mvc.ui.theme.shared/package.json Drops @abp/malihu-custom-scrollbar-plugin dependency from shared theme pack.
modules/permission-management/src/Volo.Abp.PermissionManagement.Web/Pages/AbpPermissionManagement/permission-management-modal.js Removes Malihu scrollbar initialization from permission management modal.
modules/feature-management/src/Volo.Abp.FeatureManagement.Web/Pages/FeatureManagement/feature-management-modal.js Removes Malihu scrollbar initialization from feature management modal.
modules/feature-management/src/Volo.Abp.FeatureManagement.Web/Pages/FeatureManagement/feature-management-modal.css Enables native scrolling and thin scrollbars for feature management modal sections.
modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.scss Removes Malihu-specific styling and adds native scrollbar styling for docs UI elements.
modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css Updates generated CSS to match vs.scss changes.
modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css.map Updates generated source map to match rebuilt CSS output.
modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Scripts/vs.js Removes Malihu initialization/resizing hooks from docs scripts.
modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/index.js Removes selectors that depended on Malihu-generated .mCSB_container wrappers.
modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/Index.cshtml Removes Malihu bundle contributor usage and Malihu-specific CSS class usage in markup.
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Bundling/SharedThemeGlobalStyleContributor.cs Removes Malihu style contributor dependency from shared theme global styles.
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Bundling/SharedThemeGlobalScriptContributor.cs Removes Malihu script contributor dependency from shared theme global scripts.
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/MalihuCustomScrollbar/MalihuCustomScrollbarPluginStyleBundleContributor.cs Deletes Malihu style bundle contributor implementation.
framework/src/Volo.Abp.AspNetCore.Mvc.UI.Packages/Volo/Abp/AspNetCore/Mvc/UI/Packages/MalihuCustomScrollbar/MalihuCustomScrollbarPluginScriptBundleContributor.cs Deletes Malihu script bundle contributor implementation.
docs/en/framework/ui/mvc-razor-pages/theming.md Removes Malihu mention from theming docs.
docs/en/framework/ui/mvc-razor-pages/overall.md Removes Malihu mention from overall MVC UI docs.
Files not reviewed (1)
  • modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.97%. Comparing base (3b702fa) to head (4d71b33).
⚠️ Report is 67 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #26000      +/-   ##
==========================================
- Coverage   48.99%   48.97%   -0.02%     
==========================================
  Files        3805     3813       +8     
  Lines      132259   132478     +219     
  Branches    10027    10038      +11     
==========================================
+ Hits        64796    64879      +83     
- Misses      65536    65666     +130     
- Partials     1927     1933       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace malihu-custom-scrollbar-plugin with native CSS scrollbars

3 participants