Remove the entity default index of the identity server module. - #2695
Closed
maliming wants to merge 1 commit into
Closed
Remove the entity default index of the identity server module.#2695maliming wants to merge 1 commit into
maliming wants to merge 1 commit into
Conversation
Member
|
@maliming you are removing the primary keys (they are composite PK here) of the tables, not their indexes. As I see the IDS4 implementation, they defined Id properties to the entities. But our entities has no Id property. We are implementing DDD and these entities are not aggregate roots, so we didn't define an unnecessary Id. I don't know how to solve the problem. Maybe we need to decrease the total length of the primary keys, or define an Id property for these entities (which will require the code change on the entities and other services). This would be a big breaking change. We can go with the first option if we need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2451
based on https://github.com/IdentityServer/IdentityServer4/blob/master/src/EntityFramework.Storage/src/Extensions/ModelBuilderExtensions.cs
Need to add or recreate migrations.