Skip to content

Remove the entity default index of the identity server module. - #2695

Closed
maliming wants to merge 1 commit into
devfrom
maliming/ids_index
Closed

Remove the entity default index of the identity server module.#2695
maliming wants to merge 1 commit into
devfrom
maliming/ids_index

Conversation

@maliming

Copy link
Copy Markdown
Member

@maliming maliming added this to the 2.1 milestone Jan 22, 2020
@hikalkan

Copy link
Copy Markdown
Member

@maliming you are removing the primary keys (they are composite PK here) of the tables, not their indexes.

As I see the IDS4 implementation, they defined Id properties to the entities. But our entities has no Id property. We are implementing DDD and these entities are not aggregate roots, so we didn't define an unnecessary Id.

I don't know how to solve the problem. Maybe we need to decrease the total length of the primary keys, or define an Id property for these entities (which will require the code change on the entities and other services). This would be a big breaking change. We can go with the first option if we need.

@maliming maliming closed this Jan 30, 2020
@maliming
maliming deleted the maliming/ids_index branch February 15, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Server Warning on Clustered Indexes

2 participants