Default roles on registration - #2753
Merged
Merged
Conversation
resolves #2721
hikalkan
requested changes
Feb 4, 2020
|
|
||
| public virtual async Task<List<IdentityRole>> GetDefaultOnesAsync(CancellationToken cancellationToken = default) | ||
| { | ||
| return await DbSet.Where(r => r.IsDefault).ToListAsync(cancellationToken: cancellationToken); |
Member
There was a problem hiding this comment.
Use GetCancellationToken(cancellationToken) just as like other methods.
|
|
||
| public virtual async Task<List<IdentityRole>> GetDefaultOnesAsync(CancellationToken cancellationToken = default) | ||
| { | ||
| return await GetMongoQueryable().Where(r => r.IsDefault).ToListAsync(cancellationToken: cancellationToken); |
Member
There was a problem hiding this comment.
Use GetCancellationToken(cancellationToken) just as like other methods.
| ); | ||
|
|
||
| Task<List<IdentityRole>> GetDefaultOnesAsync( | ||
| CancellationToken cancellationToken = default |
Member
There was a problem hiding this comment.
Add bool includeDetails = false parameter to be compatible to other methods. See https://docs.abp.io/en/abp/latest/Best-Practices/Repositories to learn the rules. The section below explains this rule:
hikalkan
requested changes
Feb 4, 2020
| public virtual async Task<List<IdentityRole>> GetDefaultOnesAsync( | ||
| bool includeDetails = false, CancellationToken cancellationToken = default) | ||
| { | ||
| return await DbSet.Where(r => r.IsDefault).ToListAsync(GetCancellationToken(cancellationToken)); |
Member
There was a problem hiding this comment.
Where is the implementation of the includeDetails?
Member
|
@cotur can you test this feature in the application startup template? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2721