Skip to content

Make sure the script is executed before the callback method. - #2854

Merged
ebicoglu merged 2 commits into
devfrom
maliming/abp-jquery-script
Feb 19, 2020
Merged

Make sure the script is executed before the callback method.#2854
ebicoglu merged 2 commits into
devfrom
maliming/abp-jquery-script

Conversation

@maliming

@maliming maliming commented Feb 18, 2020

Copy link
Copy Markdown
Member

$.getScript
The callback is fired once the script has been loaded but not necessarily executed.

@maliming
maliming requested a review from hikalkan February 18, 2020 11:55
@ebicoglu
ebicoglu merged commit 02f5f15 into dev Feb 19, 2020
@ebicoglu
ebicoglu deleted the maliming/abp-jquery-script branch February 19, 2020 06:54
@ebicoglu
ebicoglu requested review from ebicoglu and removed request for hikalkan February 19, 2020 06:54
@ebicoglu ebicoglu self-assigned this Feb 19, 2020
@ebicoglu ebicoglu added this to the 2.1 milestone Feb 19, 2020
@ebicoglu ebicoglu mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebicoglu ebicoglu Awaiting requested review from ebicoglu

Assignees

@ebicoglu ebicoglu

Labels

None yet

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@maliming @ebicoglu