Add push-triggered E2E testing across Personal, Business and SharePoint accounts

.github/actions/spelling/allow.txt

@@ -373,6 +373,7 @@ pastebin
 permessage
 pfa
 PFN
+pgrep
 phlibi
 phobos
 pidx
@@ -444,6 +445,7 @@ rsnapshot
 rsv
 rtud
 rul
+ruleset
 runstatedir
 runsvdir
 Ruppe

.github/workflows/e2e-business.yaml

@@ -0,0 +1,189 @@
+name: E2E Testing - Business Account
+
+on:
+  push:
+    branches-ignore:
+      - master
+      - main
+    paths:
+      - 'src/**'
+      - 'ci/**'
+      - '.github/workflows/e2e-*.yaml'
+
+permissions:
+  contents: read
+  pull-requests: write
+  issues: write
+
+jobs:
+  e2e_business:
+    runs-on: ubuntu-latest
+    container: fedora:latest
+    environment:
+      name: e2e-business
+      deployment: false
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Dependencies
+        run: |
+          dnf -y update
+          dnf -y group install development-tools
+          dnf -y install python3 ldc libcurl-devel sqlite-devel dbus-devel jq
+
+      - name: Build + local install prefix
+        run: |
+          ./configure --prefix="$PWD/.ci/prefix"
+          make -j"$(nproc)"
+          make install
+          "$PWD/.ci/prefix/bin/onedrive" --version
+
+      - name: Prepare isolated HOME
+        run: |
+          set -euo pipefail
+          export HOME="$RUNNER_TEMP/home-business"
+          echo "HOME=$HOME" >> "$GITHUB_ENV"
+          echo "XDG_CONFIG_HOME=$HOME/.config" >> "$GITHUB_ENV"
+          echo "XDG_CACHE_HOME=$HOME/.cache" >> "$GITHUB_ENV"
+          mkdir -p "$HOME"
+
+      - name: Inject refresh token into onedrive config
+        env:
+          REFRESH_TOKEN_BUSINESS: ${{ secrets.REFRESH_TOKEN_BUSINESS }}
+        run: |
+          set -euo pipefail
+          mkdir -p "$XDG_CONFIG_HOME/onedrive"
+          umask 077
+          printf "%s" "$REFRESH_TOKEN_BUSINESS" > "$XDG_CONFIG_HOME/onedrive/refresh_token"
+          chmod 600 "$XDG_CONFIG_HOME/onedrive/refresh_token"
+
+      - name: Run E2E harness
+        env:
+          ONEDRIVE_BIN: ${{ github.workspace }}/.ci/prefix/bin/onedrive
+          E2E_TARGET: business
+          RUN_ID: ${{ github.run_id }}
+          PYTHONUNBUFFERED: "1"
+        run: |
+          python3 -u ci/e2e/run.py
+
+      - name: Debug rerun failed E2E cases
+        if: always()
+        env:
+          ONEDRIVE_BIN: ${{ github.workspace }}/.ci/prefix/bin/onedrive
+          E2E_TARGET: business
+          RUN_ID: ${{ github.run_id }}
+          PYTHONUNBUFFERED: "1"
+        run: |
+          set -euo pipefail
+          if [ -f ci/e2e/out/results.json ]; then
+            python3 -u ci/e2e/rerun_failures.py \
+              --results ci/e2e/out/results.json \
+              --output-subdir debug-rerun \
+              --run-label debug-rerun \
+              --skip-suite-cleanup
+          else
+            echo "No primary results.json found; skipping debug rerun"
+          fi
+
+      - name: Upload E2E artefacts
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: e2e-business
+          path: ci/e2e/out/**
+
+  pr_comment:
+    name: Post PR summary comment
+    needs: [ e2e_business ]
+    runs-on: ubuntu-latest
+    if: always()
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Download artefact
+        uses: actions/download-artifact@v4
+        with:
+          name: e2e-business
+          path: artifacts/e2e-business
+
+      - name: Build markdown summary
+        id: summary
+        run: |
+          set -euo pipefail
+
+          primary_results="artifacts/e2e-business/results.json"
+          if [ -f "$primary_results" ]; then
+            f="$primary_results"
+          else
+            f="$(find artifacts/e2e-business \
+              -path '*/debug-rerun/*' -prune -o \
+              -name results.json -type f -print | head -n 1 || true)"
+          fi
+          if [ -z "$f" ] || [ ! -f "$f" ]; then
+            echo "md=⚠️ E2E ran but results.json was not found." >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          target=$(jq -r '.target // "business"' "$f")
+          total=$(jq -r '.cases | length' "$f")
+          passed=$(jq -r '[.cases[] | select(.status=="pass")] | length' "$f")
+          failed=$(jq -r '[.cases[] | select(.status=="fail")] | length' "$f")
+
+          failures=$(jq -r '.cases[]
+            | select(.status=="fail")
+            | "- Test Case \(.id // "????"): \(.name) — \(.reason // "no reason provided")"' "$f" || true)
+
+          md="## ${target^} Account Testing\n"
+          md+="**${total}** Test Cases Run  \n"
+          md+="**${passed}** Test Cases Passed  \n"
+          md+="**${failed}** Test Cases Failed  \n\n"
+
+          if [ "$failed" -gt 0 ] && [ -n "$failures" ]; then
+            md+="### ${target^} Account Test Failures\n"
+            md+="$failures\n"
+          fi
+
+          echo "md<<EOF" >> "$GITHUB_OUTPUT"
+          echo -e "$md" >> "$GITHUB_OUTPUT"
+          echo "EOF" >> "$GITHUB_OUTPUT"
+
+      - name: Find PR associated with this commit
+        id: pr
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { owner, repo } = context.repo;
+            const sha = context.sha;
+
+            const prs = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+              owner, repo, commit_sha: sha
+            });
+
+            if (!prs.data.length) {
+              core.setOutput("found", "false");
+              return;
+            }
+
+            core.setOutput("found", "true");
+            core.setOutput("number", String(prs.data[0].number));
+
+      - name: Post PR comment
+        if: steps.pr.outputs.found == 'true'
+        uses: actions/github-script@v7
+        env:
+          COMMENT_MD: ${{ steps.summary.outputs.md }}
+        with:
+          script: |
+            const { owner, repo } = context.repo;
+            const issue_number = Number("${{ steps.pr.outputs.number }}");
+
+            const md = process.env.COMMENT_MD || "⚠️ No summary text produced.";
+
+            await github.rest.issues.createComment({
+              owner,
+              repo,
+              issue_number,
+              body: md
+            });

.github/workflows/e2e-personal-15char-check.yaml

@@ -0,0 +1,189 @@
+name: E2E Testing - Personal Account with 15 Character driveId Check
+
+on:
+  push:
+    branches-ignore:
+      - master
+      - main
+    paths:
+      - 'src/**'
+      - 'ci/**'
+      - '.github/workflows/e2e-*.yaml'
+
+permissions:
+  contents: read
+  pull-requests: write
+  issues: write
+
+jobs:
+  e2e_personal:
+    runs-on: ubuntu-latest
+    container: fedora:latest
+    environment:
+      name: e2e-personal-15char-check
+      deployment: false
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Dependencies
+        run: |
+          dnf -y update
+          dnf -y group install development-tools
+          dnf -y install python3 ldc libcurl-devel sqlite-devel dbus-devel jq
+
+      - name: Build + local install prefix
+        run: |
+          ./configure --prefix="$PWD/.ci/prefix"
+          make -j"$(nproc)"
+          make install
+          "$PWD/.ci/prefix/bin/onedrive" --version
+
+      - name: Prepare isolated HOME
+        run: |
+          set -euo pipefail
+          export HOME="$RUNNER_TEMP/home-personal"
+          echo "HOME=$HOME" >> "$GITHUB_ENV"
+          echo "XDG_CONFIG_HOME=$HOME/.config" >> "$GITHUB_ENV"
+          echo "XDG_CACHE_HOME=$HOME/.cache" >> "$GITHUB_ENV"
+          mkdir -p "$HOME"
+
+      - name: Inject refresh token into onedrive config
+        env:
+          REFRESH_TOKEN_PERSONAL: ${{ secrets.REFRESH_TOKEN_PERSONAL }}
+        run: |
+          set -euo pipefail
+          mkdir -p "$XDG_CONFIG_HOME/onedrive"
+          umask 077
+          printf "%s" "$REFRESH_TOKEN_PERSONAL" > "$XDG_CONFIG_HOME/onedrive/refresh_token"
+          chmod 600 "$XDG_CONFIG_HOME/onedrive/refresh_token"
+
+      - name: Run E2E harness
+        env:
+          ONEDRIVE_BIN: ${{ github.workspace }}/.ci/prefix/bin/onedrive
+          E2E_TARGET: personal
+          RUN_ID: ${{ github.run_id }}
+          PYTHONUNBUFFERED: "1"
+        run: |
+          python3 -u ci/e2e/run.py
+
+      - name: Debug rerun failed E2E cases
+        if: always()
+        env:
+          ONEDRIVE_BIN: ${{ github.workspace }}/.ci/prefix/bin/onedrive
+          E2E_TARGET: personal
+          RUN_ID: ${{ github.run_id }}
+          PYTHONUNBUFFERED: "1"
+        run: |
+          set -euo pipefail
+          if [ -f ci/e2e/out/results.json ]; then
+            python3 -u ci/e2e/rerun_failures.py \
+              --results ci/e2e/out/results.json \
+              --output-subdir debug-rerun \
+              --run-label debug-rerun \
+              --skip-suite-cleanup
+          else
+            echo "No primary results.json found; skipping debug rerun"
+          fi
+
+      - name: Upload E2E artefacts
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: e2e-personal-15char-check
+          path: ci/e2e/out/**
+
+  pr_comment:
+    name: Post PR summary comment
+    needs: [ e2e_personal ]
+    runs-on: ubuntu-latest
+    if: always()
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Download artefact
+        uses: actions/download-artifact@v4
+        with:
+          name: e2e-personal-15char-check
+          path: artifacts/e2e-personal-15char-check
+
+      - name: Build markdown summary
+        id: summary
+        run: |
+          set -euo pipefail
+
+          primary_results="artifacts/e2e-personal-15char-check/results.json"
+          if [ -f "$primary_results" ]; then
+            f="$primary_results"
+          else
+            f="$(find artifacts/e2e-personal-15char-check \
+              -path '*/debug-rerun/*' -prune -o \
+              -name results.json -type f -print | head -n 1 || true)"
+          fi
+          if [ -z "$f" ] || [ ! -f "$f" ]; then
+            echo "md=⚠️ E2E ran but results.json was not found." >> "$GITHUB_OUTPUT"
+            exit 0
+          fi
+
+          target=$(jq -r '.target // "personal"' "$f")
+          total=$(jq -r '.cases | length' "$f")
+          passed=$(jq -r '[.cases[] | select(.status=="pass")] | length' "$f")
+          failed=$(jq -r '[.cases[] | select(.status=="fail")] | length' "$f")
+
+          failures=$(jq -r '.cases[]
+            | select(.status=="fail")
+            | "- Test Case \(.id // "????"): \(.name) — \(.reason // "no reason provided")"' "$f" || true)
+
+          md="## ${target^} Account Testing - 15 Character 'driveId'\n"
+          md+="**${total}** Test Cases Run  \n"
+          md+="**${passed}** Test Cases Passed  \n"
+          md+="**${failed}** Test Cases Failed  \n\n"
+
+          if [ "$failed" -gt 0 ] && [ -n "$failures" ]; then
+            md+="### ${target^} Account Test Failures\n"
+            md+="$failures\n"
+          fi
+
+          echo "md<<EOF" >> "$GITHUB_OUTPUT"
+          echo -e "$md" >> "$GITHUB_OUTPUT"
+          echo "EOF" >> "$GITHUB_OUTPUT"
+
+      - name: Find PR associated with this commit
+        id: pr
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { owner, repo } = context.repo;
+            const sha = context.sha;
+
+            const prs = await github.rest.repos.listPullRequestsAssociatedWithCommit({
+              owner, repo, commit_sha: sha
+            });
+
+            if (!prs.data.length) {
+              core.setOutput("found", "false");
+              return;
+            }
+
+            core.setOutput("found", "true");
+            core.setOutput("number", String(prs.data[0].number));
+
+      - name: Post PR comment
+        if: steps.pr.outputs.found == 'true'
+        uses: actions/github-script@v7
+        env:
+          COMMENT_MD: ${{ steps.summary.outputs.md }}
+        with:
+          script: |
+            const { owner, repo } = context.repo;
+            const issue_number = Number("${{ steps.pr.outputs.number }}");
+
+            const md = process.env.COMMENT_MD || "⚠️ No summary text produced.";
+
+            await github.rest.issues.createComment({
+              owner,
+              repo,
+              issue_number,
+              body: md
+            });