Skip to content

Conversation

@Maite2003
Copy link
Contributor

Bug Fix in appleAlarms.py:
Fixed data alignment issue by adding None placeholder in alarm time column for sleep alarms when no alarm time was present.

Standardization Across Multiple Modules:
Updated function signatures: Changed to use context parameter
plist processing in appItunesmeta.py: Replaced direct plist library calls with get_plist_file_content() function

Updated the artifact to use context. Removed unused code, deprecated timezone offset handling
Replaces direct plist parsing and deserialization with the get_plist_file_content. Removes unused imports

data_list.append(
(fire_date,
None, # alarm time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch on this data misalignment. i am not super familiar with this artifact, is the 'MTSleepAlarm' condition never having a time? did you find any examples to validate in test data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just put None in there to fix the alignment. I thought about getting the hour and minute to build the time string, but I have no idea what the internal structure for that artifact looks like and didn't want to assume those fields exist. I couldn't find any test data.

Added checks to ensure that parsed plist files are valid dictionaries before accessing their contents.
Added checks to ensure plist files are valid and dictionaries before processing
@JamesHabben JamesHabben added the Artifact Module Update related to an artifact module label Nov 6, 2025
@JamesHabben
Copy link
Collaborator

sorry for the delay on this. can we fix the linter errors? then i think we are good to merge.

scripts/artifacts/appItunesmeta.py:18:0: W0401: Wildcard import datetime (wildcard-import)
scripts/artifacts/appItunesmeta.py:18:0: W0614: Unused import(s) sys, MINYEAR, MAXYEAR, dbm, dim, timedelta, date, tzinfo, IsoCalendarDate, time, datetime, timezone, UTC and datetime_CAPI from wildcard import of datetime (unused-wildcard-import)
************* Module appleAlarms
scripts/artifacts/appleAlarms.py:59:16: W0621: Redefining name 'alarms' from outer scope (line 46) (redefined-outer-name)
************* Module appleMapsGroup
scripts/artifacts/appleMapsGroup.py:45:37: W0612: Unused variable 'di' (unused-variable)

@Maite2003
Copy link
Contributor Author

@JamesHabben I fixed the errors!

@stark4n6 stark4n6 merged commit 16b6762 into abrignoni:main Dec 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Artifact Module Update related to an artifact module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants