fix(system_version_plist): correct data source assignment #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug in systemVersionPlist.py that causes the artifact parser to crash with a
TypeError.The crash was caused by passing the function object
system_version_plistto the plist parser instead of the file path stringplist_file. This occurred due to a variable naming error where the function name was used in an assignment statement instead of the local variable holding the path.Changes
plist_fileinstead ofsystem_version_plist.get_plist_file_contentfunction now receives a valid string path, allowing the artifact to parse successfully and extract iOS version information.Verification & Testing
I have created a reproduction script (test_sysversion_fix.py) to verify the fix.
get_plist_file_contentArgument Type validation.data_sourceAssignment Validation.Test Output Summary:
Checklist
Related Issues
Closes #1390