MG-57 - Update Kubernetes Development Guide with Latest Enhancements #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JeffMboya Please rebase |
JeffMboya
force-pushed
the
updatedocs
branch
2 times, most recently
from
d91c5dc to
963cd4a
Compare
JeffMboya
changed the title
Musilah
requested changes
May 13, 2025
docs/dev-guide/kubernetes.md
Outdated
|
|
||
| This means: | ||
|
|
||
| * `re.secrets.names` is **set** but **empty** (`[]`). |
There was a problem hiding this comment.
Use hyphens for unordered lists instead.
docs/dev-guide/kubernetes.md
Outdated
|
|
||
| That logic **fails when `re.secrets.names: []` is present**, because: | ||
|
|
||
| * The block for `envFrom` renders **nothing**. |
There was a problem hiding this comment.
Use hyphens or dashes for this list as well.
docs/dev-guide/kubernetes.md
Outdated
| After deploying Magistrala, verify the services and pods using `kubectl` commands: | ||
| Once the chart is installed, you can verify that Magistrala is running correctly: | ||
|
|
||
| #### View all resources in the `mg` namespace: |
There was a problem hiding this comment.
Remove the colons from headings. This results in a trailing punctuation lint error.
nyagamunene
approved these changes
May 13, 2025
Musilah
reviewed
May 13, 2025
Add step to remove finalizers Update docs Signed-off-by: JeffMboya <[email protected]> Add loki installation verification Signed-off-by: JeffMboya <[email protected]> Add log viewing using grafana Signed-off-by: JeffMboya <[email protected]> Rename mg to smq Signed-off-by: JeffMboya <[email protected]> Update docs Signed-off-by: JeffMboya <[email protected]> Document harbor Signed-off-by: JeffMboya <[email protected]> Rename supermq to Magistrala Signed-off-by: JeffMboya <[email protected]> Update docs Signed-off-by: JeffMboya <[email protected]> Update docs Signed-off-by: JeffMboya <[email protected]> Update docs Signed-off-by: JeffMboya <[email protected]> Update docs Signed-off-by: JeffMboya <[email protected]> Document RE email config handling Signed-off-by: JeffMboya <[email protected]> Update dosc Signed-off-by: JeffMboya <[email protected]> Address comments Signed-off-by: JeffMboya <[email protected]> Address comments Signed-off-by: JeffMboya <[email protected]> Address comments Signed-off-by: JeffMboya <[email protected]> Address comments Signed-off-by: JeffMboya <[email protected]> Address comments Signed-off-by: JeffMboya <[email protected]> Address comments Signed-off-by: JeffMboya <[email protected]> Update docs/dev-guide/kubernetes.md Co-authored-by: Nataly Musilah <[email protected]> Update docs/dev-guide/kubernetes.md Co-authored-by: Nataly Musilah <[email protected]> Update docs/dev-guide/kubernetes.md Co-authored-by: Nataly Musilah <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Musilah
reviewed
May 15, 2025
docs/dev-guide/rules-engine.md
Outdated
|
|
||
| Topic: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```bash |
docs/dev-guide/rules-engine.md
Outdated
|
|
||
| Becomes: | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```bash |
docs/dev-guide/rules-engine.md
Outdated
|
|
||
| This means: | ||
|
|
||
| * MQTT `/` separators are rewritten as `.` internally |
There was a problem hiding this comment.
Use hyphens for unordered lists
Signed-off-by: JeffMboya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
re.secrets.namesis defined as an empty listmagistrala-devopsreferencesWhich issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes