SMQ-2875 - Add listing entities by multiple tag values with support for AND/OR conditions #3154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3154 +/- ##
===========================================
+ Coverage 35.54% 47.35% +11.80%
===========================================
Files 307 140 -167
Lines 39233 24063 -15170
===========================================
- Hits 13945 11394 -2551
+ Misses 24440 11960 -12480
+ Partials 848 709 -139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dborovcanin
force-pushed
the
mg291-tags
branch
from
be99e80 to
27e50ee
Compare
dborovcanin
requested changes
Sep 25, 2025
clients/api/http/endpoints_test.go
Outdated
| token: validToken, | ||
| authnRes: smqauthn.Session{UserID: validID, DomainID: domainID, DomainUserID: domainID + "_" + validID, SuperAdmin: false}, | ||
| query: "list_perms=true&listPerms=true", | ||
| query: "metadata=%7B%22domain%22%3A%20%22example.com%22%7D&metadata=%7B%22domain%22%3A%20%22example.com%22%7D", |
There was a problem hiding this comment.
Use url.PathEscape() instead of manually providing escaped path.
There was a problem hiding this comment.
@felixgateru This has not been addressed yet.
|
Please fix tests. |
felixgateru
force-pushed
the
mg291-tags
branch
2 times, most recently
from
d75749d to
f1d1812
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
felixgateru
force-pushed
the
mg291-tags
branch
from
f1d1812 to
5b942ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds functionality to list entities by multiple tag values with support for AND/OR conditions
What does this do?
This pr:
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, tests have been updated.
Did you document any new/modified feature?
Yes, in code documentation as well as updates to the OpenAPI spec are included
Notes