SMQ-3173 - Use buildx for Multi-Platform Docker Image Support
#3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
feat/riscv-support
branch
3 times, most recently
from
b9780c9 to
9a544de
Compare
dborovcanin
requested changes
Oct 13, 2025
docker/Dockerfile.dev
Outdated
| ARG SVC | ||
| COPY $SVC /exe | ||
| COPY --from=alpine:latest /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt | ||
| COPY --from=alpine /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt |
There was a problem hiding this comment.
No need for naming alpine stage (FROM alpine:3.22 AS alpine), we can use COPY --from=alpine:3.22 /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt
.github/workflows/build.yaml
Outdated
| contents: read | ||
|
|
||
| steps: | ||
| - name: Free Disk Space (Ubuntu) |
There was a problem hiding this comment.
This is because we run out of space when building the images. I had initially started with a larger pool darwin/amd64,darwin/arm64,freebsd/amd64,freebsd/arm64,netbsd/amd64,netbsd/arm64,openbsd/amd64,openbsd/arm64,linux/amd64,linux/arm64,linux/riscv64,windows/amd64,windows/arm64, this is when I experienced it
Makefile
Outdated
| $(eval svc=$(subst docker_,,$(1))) | ||
|
|
||
| docker build \ | ||
| --platform linux/amd64,linux/arm64,linux/riscv64 \ |
There was a problem hiding this comment.
Let's switch to buildx.
rodneyosodo
force-pushed
the
feat/riscv-support
branch
2 times, most recently
from
ec60a0c to
064ada4
Compare
dborovcanin
requested changes
Oct 13, 2025
|
@rodneyosodo Any updates on this? |
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
This image supports riscv and arm architectures Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
feat/riscv-support
branch
from
064ada4 to
f22eefe
Compare
rodneyosodo
changed the title
riscv64 Architecture Support for Docker Image buildx for Multi-Platform Docker Image Support
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
feat/riscv-support
branch
from
6e41eab to
e5144ed
Compare
dborovcanin
requested changes
Nov 4, 2025
Makefile
Outdated
|
|
||
| docker build \ | ||
| docker buildx build --load \ | ||
| --platform linux/amd64 \ |
There was a problem hiding this comment.
Let's add a Makefile target for building and tagging dockers for different architecture.
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
feat/riscv-support
branch
from
dd57604 to
5cfbfa2
Compare
Signed-off-by: Rodney Osodo <[email protected]>
For Linux ARM64: make publish_arch GOOS=linux GOARCH=arm64 For Linux RISC-V 64: make publish_arch GOOS=linux GOARCH=riscv64 For Linux ARM v7: make publish_arch GOOS=linux GOARCH=arm GOARM=7 Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
feat/riscv-support
branch
from
f23559b to
f515270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds riscv support
What does this do?
Adds riscv support
Which issue(s) does this PR fix/relate to?
riscv64Architecture Support for Official PostgreSQL Docker Image #3172Have you included tests for your changes?
Yes, tested manually https://hub.docker.com/r/rodneydav/supermq-users/tags
Did you document any new/modified feature?
Notes