Skip to content

Drop dependency on qdbus for run-or-raise functionality #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voidpntr
Copy link

On my Arch system qdbus is not in PATH because I have only qt6-tools installed which puts qdbus in /usr/lib/qt6/bin/. qt5-tools would provide it in /usr/bin/ but I don't use any software that pulls it in.

For people with a similar setup ww does not work out of the box. This patch fixes it for the run-or-raise codepath.

I did not remove the last qdbus dependency in -ia mode because the output format would change from

activities: e95f6959-43e3-4e95-a42b-3ce622137856
caption: ww-run-raise : bash — Konsole
clientMachine: localhost
desktopFile: org.kde.konsole
desktops: 8530ccdc-c6aa-4c2f-a76f-9dcd890f89a6
fullscreen: false
...

to

method return time=1745072712.820071 sender=:1.13 -> destination=:1.188 serial=1168 reply_serial=2
   array [
      dict entry(
         string "activities"
         variant             array [
               string "e95f6959-43e3-4e95-a42b-3ce622137856"
            ]
      )
      dict entry(
         string "caption"
         variant             string "ww-run-raise : bash — Konsole"
      )
      dict entry(
         string "clientMachine"
         variant             string "localhost"
      )
      dict entry(
         string "desktopFile"
         variant             string "org.kde.konsole"
      )

Also,

  • --session is the default for dbus-send, remove
  • .run and .stop do not output anything for me, remove useless redirects

Also,
- `--session` is the default for dbus-send, remove
- .run and .stop do not output anything for me, remove useless redirects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant