Groups-based Action Decorator System - #430
Open
azht wants to merge 8 commits into
Open
Conversation
Cancel-of-cancel bypassed authorization because the cancel handler
registered its response-send task in _action_tasks without recording a
requester. Split fire-and-forget response sends into _response_tasks so
they are never cancellable, and drain them on shutdown without
cancelling, so a denied requester always learns their request was
refused.
Also add the ownerless-registration bypass to _authorized_for_cancel to
match its sibling helpers, and guard the empty client_groups header in
get_client_info so a group-less client parses to set() rather than {''}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds groups-based access control for shared agents. Agents can declare which Globus groups may invoke each action via a sharing param on the @action decorator with union semantics across groups. Currently sharing=[] makes an action owner-only, and ommiting it falls back to the union of all groups declared on that agent's actions.
Decisions
Related Issues
Changes
Testing
Added test covering: per-action sharing authorization (allow/deny/owner), explicit empty sharing (owner-only), fallback to the agent group union for undecorated (agree with Alok, this preserves past behavior), owner-only shutdown, response delivery to unshared mailboxes, ownership checks in create/termiante/put, owner propagation through agent registration (maybe a few more?). All tests in the touched files pass locally (156 passed).
Pull Request Checklist
Please confirm the PR meets the following requirements.
pre-commit(e.g., ruff, mypy, etc.). ✅ 2026-07-15