ODP:6525 Fix compilation issues in TestServiceDBStore#140
Open
architlatkar27 wants to merge 1 commit intorel/ODP-3.3.6.4-1from
Open
ODP:6525 Fix compilation issues in TestServiceDBStore#140architlatkar27 wants to merge 1 commit intorel/ODP-3.3.6.4-1from
architlatkar27 wants to merge 1 commit intorel/ODP-3.3.6.4-1from
Conversation
architlatkar27
commented
Apr 28, 2026
|
|
||
| // Execute | ||
| List<org.apache.ranger.s3.PolicyStatement> result = | ||
| serviceDBStore.extractIAMOnlyStatements(iamStatements, rangerStatements); |
Author
There was a problem hiding this comment.
def of this method is conflicting across ODP-main and 3.3.6.4-1 branches
Could you please verify once if this change is to be kept or not?
Author
There was a problem hiding this comment.
For ref - it expects Set in 3.3.6.4-1 but expects List in ODP main
which one is the correct one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix compilation issues in TestServiceDBStore
How was this patch tested?
mvn test -pl security-admin -Dtest=TestServiceDBStore -DfailIfNoTests=false
Build was successful