fix(core): normalize line endings in template hash calculation#826
Merged
mttrbrts merged 1 commit intoaccordproject:mainfrom Feb 24, 2026
Merged
Conversation
Signed-off-by: siddhant jain <siddhantjainofficial26@gmail.com>
mttrbrts
approved these changes
Feb 14, 2026
auto-merge was automatically disabled
February 24, 2026 09:34
Pull request was closed
Pull Request Test Coverage Report for Build 22344927585Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a cross-platform compatibility issue where template hash calculations would fail on Windows due to line-ending differences (CRLF vs LF).
The Issue
The
getHash()method incicero-corecalculates a SHA-256 fingerprint based on the raw string contents of the template (Grammar, Models, Scripts, README, etc.).\n(LF).\r\n(CRLF).Because the hash function did not normalize these strings, the same template would generate different hashes on different operating systems, causing unit tests (
should roundtrip a template,should return a SHA-256 hash) to fail locally for Windows developers.The Fix
I added a private
_normalize(str)helper method to theTemplateclass.\r) characters from strings before they are added to the content object used for hashing.Verification
Ran
npm testlocally on a Windows environment.Template(hash mismatch).Checklist
--signoffoption of git commit.mainfromfork:branchname