Skip to content

fix: scroll of Explore button to the footer#136

Merged
DianaLease merged 2 commits intoaccordproject:mainfrom
Adi-204:Adi-204/fix-explore-button
Mar 5, 2025
Merged

fix: scroll of Explore button to the footer#136
DianaLease merged 2 commits intoaccordproject:mainfrom
Adi-204:Adi-204/fix-explore-button

Conversation

@Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Feb 28, 2025

Closes #106

Fix the Explore CTA Void on Nav to scroll to the footer.

Changes

  • Change the scrolltoExplore -> scrolltoFooter for Explore button in Nav
  • Made changes in testcase

Screenshots or Video

Untitled.video.-.Made.with.Clipchamp.mp4

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • [] Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: Adi-204 <adiboghawala@gmail.com>
@Adi-204 Adi-204 requested a review from a team as a code owner February 28, 2025 20:21
@netlify
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 2dd18ff
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67c2e0b4e10a7300089688dd
😎 Deploy Preview https://deploy-preview-136--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vinyl-Davyl
Copy link
Collaborator

Vinyl-Davyl commented Feb 28, 2025

Hey @Adi-204 Thanks for contributing :)
Please can you remove the id="explore" that should be in the src/App.tsx as it is no longer of use in this case from this PR. And also update the dormant onClick={scrollToExplore} on the md screens line 145. And test to ensure they work.

@Adi-204
Copy link
Contributor Author

Adi-204 commented Mar 1, 2025

Hey @Adi-204 Thanks for contributing :) Please can you remove the id="explore" that should be in the src/App.tsx as it is no longer of use in this case from this PR. And also update the dormant onClick={scrollToExplore} on the md screens line 145. And test to ensure they work.

@Vinyl-Davyl Sir I will remove id="explore" from src/App.tsx.
Sir I have already changed all the instance of scrollToExplore to scrollToFooter in PR. Can you please explain and provide feedback thanks : )

Signed-off-by: Adi-204 <adiboghawala@gmail.com>
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DianaLease DianaLease merged commit 415d6b0 into accordproject:main Mar 5, 2025
7 checks passed
ansh7432 pushed a commit to ansh7432/template-playground that referenced this pull request Mar 6, 2025
* fix: scroll of Explore button to the footer

Signed-off-by: Adi-204 <adiboghawala@gmail.com>

* refactor: removed explore id

Signed-off-by: Adi-204 <adiboghawala@gmail.com>

---------

Signed-off-by: Adi-204 <adiboghawala@gmail.com>
Signed-off-by: ansh7432 <anshsoni743@gmail.com>
ansh7432 pushed a commit to ansh7432/template-playground that referenced this pull request Mar 6, 2025
* fix: scroll of Explore button to the footer

Signed-off-by: Adi-204 <adiboghawala@gmail.com>

* refactor: removed explore id

Signed-off-by: Adi-204 <adiboghawala@gmail.com>

---------

Signed-off-by: Adi-204 <adiboghawala@gmail.com>
Signed-off-by: ansh7432 <anshsoni743@gmail.com>
ansh7432 pushed a commit to ansh7432/template-playground that referenced this pull request Mar 6, 2025
* fix: scroll of Explore button to the footer

Signed-off-by: Adi-204 <adiboghawala@gmail.com>

* refactor: removed explore id

Signed-off-by: Adi-204 <adiboghawala@gmail.com>

---------

Signed-off-by: Adi-204 <adiboghawala@gmail.com>
Signed-off-by: ansh7432 <anshsoni743@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explore CTA is void on nav, Reupdate nav contents and adjust test cases to reflect changes.

3 participants