Skip to content

Fix(Editor Theme): Monaco Editor Dark Mode theme Fixed#139

Merged
DianaLease merged 1 commit intoaccordproject:mainfrom
nitro56565:nitro56565/bug/dark-mode-monaco
Mar 5, 2025
Merged

Fix(Editor Theme): Monaco Editor Dark Mode theme Fixed#139
DianaLease merged 1 commit intoaccordproject:mainfrom
nitro56565:nitro56565/bug/dark-mode-monaco

Conversation

@nitro56565
Copy link
Contributor

@nitro56565 nitro56565 commented Mar 1, 2025

Summary

This PR fixes the Monaco Editor's theme issue while toggling dark mode which was mistakenly removed in my PR #128 to ensure consistency with the overall theme I have restored the theme logic again. Apologies for the mistake.

Changes

  • Initiated the useEffect block to trigger the theme for the Monaco Editor

Screenshots or Video

Screenshot From 2025-03-01 17-51-56
image

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Signed-off-by: nitro56565 <nitro56565@gmail.com>
@nitro56565 nitro56565 requested a review from a team as a code owner March 1, 2025 12:32
@netlify
Copy link

netlify bot commented Mar 1, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit ff05e51
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67c2fe530411d50008e91d0c
😎 Deploy Preview https://deploy-preview-139--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DianaLease DianaLease merged commit 4abc864 into accordproject:main Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants