Adds Outline to Toggle NitghtMode button In DarkMode for better visibility#145
Merged
DianaLease merged 2 commits intoaccordproject:mainfrom Mar 10, 2025
Merged
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: yugal07 <yashsadhwani544@gmail.com>
24f2da6 to
31e955b
Compare
DianaLease
requested changes
Mar 7, 2025
Member
DianaLease
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Can you merge the latest main with your branch and resolve conflicts?
…into issue-nighmode-outline
Contributor
Author
|
@DianaLease I have made the requested changes. PTAL. |
DianaLease
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Changes
1.Added a white outline to the toggle button inside the dark mode switch
2.Used stroke styling for the inner circle element to enhance visibility
3.Ensured compatibility with both dark and light modes
Flags
1.Needs testing on different screen sizes to ensure proper alignment
2.Verify accessibility improvements in high-contrast mode
Screenshots or Video
before

After

Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname