Skip to content

Adds Outline to Toggle NitghtMode button In DarkMode for better visibility#145

Merged
DianaLease merged 2 commits intoaccordproject:mainfrom
yugal07:issue-nighmode-outline
Mar 10, 2025
Merged

Adds Outline to Toggle NitghtMode button In DarkMode for better visibility#145
DianaLease merged 2 commits intoaccordproject:mainfrom
yugal07:issue-nighmode-outline

Conversation

@yugal07
Copy link
Contributor

@yugal07 yugal07 commented Mar 2, 2025

Closes #144

Changes

1.Added a white outline to the toggle button inside the dark mode switch
2.Used stroke styling for the inner circle element to enhance visibility
3.Ensured compatibility with both dark and light modes

Flags

1.Needs testing on different screen sizes to ensure proper alignment
2.Verify accessibility improvements in high-contrast mode

Screenshots or Video

before
Screenshot from 2025-03-02 15-36-38

After
Screenshot from 2025-03-02 15-36-50

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@yugal07 yugal07 requested a review from a team as a code owner March 2, 2025 10:27
@netlify
Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit c4152ae
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67ca940c81752500089024fb
😎 Deploy Preview https://deploy-preview-145--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: yugal07 <yashsadhwani544@gmail.com>
@yugal07 yugal07 force-pushed the issue-nighmode-outline branch from 24f2da6 to 31e955b Compare March 2, 2025 10:29
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you merge the latest main with your branch and resolve conflicts?

@yugal07
Copy link
Contributor Author

yugal07 commented Mar 7, 2025

@DianaLease I have made the requested changes. PTAL.

@DianaLease DianaLease merged commit c614c31 into accordproject:main Mar 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add White Outline to Toggle Button in Dark Mode Toggle

2 participants