Fix memory leak in Navbar component by updating useSpring animation#150
Fix memory leak in Navbar component by updating useSpring animation#150DianaLease merged 2 commits intoaccordproject:mainfrom sancheet230:main
Navbar component by updating useSpring animation#150Conversation
Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think this PR is ready for review @sanketshevkar @DianaLease @mttrbrts @dselman |
DianaLease
left a comment
There was a problem hiding this comment.
Please remove the comment. otherwise, looks great!
|
@DianaLease @nitro56565 I forgot to add DCO sign-off for the second commit in this PR deleting the comments and I don't have enough permissions to edit commit message So can you help me out |
Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in>
|
Hey @sancheet230, whenever you forget to signoff you have to rebase and then force push with sign off (you can also read about this in workflow approvals checks, just click on the DCO and read the doc) |
|
@nitro56565 Thanks a lot for the help it worked |
|
@DianaLease I have removed the unwanted comments you can review again now |
|
@DianaLease @nitro56565 And I think Accord Project Slack is not working So is there any method to connect to maintainers or community cause I have some doubts |
We use Discord: https://discord.com/invite/Zm99SKhhtA |
…ation (accordproject#150) * This is my commit message Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in> * Removing unwanted comments Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in> --------- Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in> Signed-off-by: ansh7432 <anshsoni743@gmail.com>
…ation (accordproject#150) * This is my commit message Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in> * Removing unwanted comments Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in> --------- Signed-off-by: sancheet230 <sancheet.p24@medhaviskillsuniversity.edu.in> Signed-off-by: ansh7432 <anshsoni743@gmail.com>
This PR fixes a potential memory leak in the
Navbarcomponent by modifying the animation logic to avoid an infinite loop within theuseSpringhook. TheuseSpringanimation now uses theloop: trueconfiguration to handle the animation looping correctly without causing memory leaks or performance issues when the component unmounts.Changes
while (true)) inside the useSpring hook with theloop: trueoption to handle the animation properly and avoid memory leaks.Related Issues
useSpringAnimation insrc/components/Navbar.tsx#148Author Checklist
--signoffoption of git commit.mainfromfork:branchname