Skip to content

fix(navbar): improve responsiveness for better user experience#174

Merged
DianaLease merged 4 commits intoaccordproject:mainfrom
surya4419:surya4419/i172/Navbar-responsiveness-issue
Mar 26, 2025
Merged

fix(navbar): improve responsiveness for better user experience#174
DianaLease merged 4 commits intoaccordproject:mainfrom
surya4419:surya4419/i172/Navbar-responsiveness-issue

Conversation

@surya4419
Copy link
Contributor

The navbar was not responsive on smaller screens, causing layout issues.
This update ensures the navbar adapts properly across different screen sizes
by implementing a more flexible design.

Refs: #172

Closes #172

Changes

  • Refactored the navbar component for better responsiveness
  • Updated styles to ensure a smooth user experience across devices

Flags

  • Ensure the new changes do not affect other UI elements
  • Test on different screen sizes before merging

Screenshots or Video

Before Changes
navbar
nav

After Changes
new nav

nv

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@surya4419 surya4419 requested a review from a team as a code owner March 5, 2025 18:29
@netlify
Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 5e08aa0
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67e365343bfeea00089ad7ea
😎 Deploy Preview https://deploy-preview-174--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the "explore" button on smaller screens? It scrolls to the footer in desktop view but the footer is removed in smaller views so it seems like that button shouldn't be shown when the footer is removed.

@surya4419
Copy link
Contributor Author

Thanks for the feedback! @DianaLease However, I noticed that another recent PR(#190 ) added the footer back on smaller screens. Since the footer is now present, the "Explore" button remains relevant.
Would you like me to keep the "Explore" button as it is, given the new footer addition, or would you prefer that I remove it? Please let me know how you'd like to proceed.

@surya4419
Copy link
Contributor Author

@DianaLease Thanks for your feedback earlier! Since PR #190 has now been successfully merged, the footer is back on smaller screens, making the "Explore" button still relevant. Given this update, could you please review my PR again and let me know if any further changes are needed?

@DianaLease
Copy link
Member

@DianaLease Thanks for your feedback earlier! Since PR #190 has now been successfully merged, the footer is back on smaller screens, making the "Explore" button still relevant. Given this update, could you please review my PR again and let me know if any further changes are needed?

That makes sense, can you update your branch with the latest main and resolve conflicts so that we can test that it's working with the latest changes? Thanks!

@surya4419 surya4419 force-pushed the surya4419/i172/Navbar-responsiveness-issue branch from 5486f2b to 969804e Compare March 11, 2025 17:01
@surya4419
Copy link
Contributor Author

@DianaLease , I have updated my branch with the latest main and resolved all conflicts. Everything should be good to go for testing now. Let me know if you need any further changes. Thanks!

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you removed the animation from the "Learn" button? If not, can you add that back?

@surya4419 surya4419 force-pushed the surya4419/i172/Navbar-responsiveness-issue branch from 969804e to 1546518 Compare March 13, 2025 04:13
@surya4419
Copy link
Contributor Author

Is there a reason you removed the animation from the "Learn" button? If not, can you add that back?

I’ve re-added the animation for the 'Learn' button. Please take a look at my PR when you get a chance. Let me know if any further adjustments are needed!"

@surya4419 surya4419 force-pushed the surya4419/i172/Navbar-responsiveness-issue branch 3 times, most recently from d675ed7 to 9605546 Compare March 14, 2025 15:57
@surya4419
Copy link
Contributor Author

@DianaLease could you please review my PR again.

@DianaLease
Copy link
Member

@surya4419 can you check the failing tests?

Signed-off-by: surya4419 <suryaa4419@gmail.com>
@surya4419 surya4419 force-pushed the surya4419/i172/Navbar-responsiveness-issue branch from 9605546 to 3704f86 Compare March 19, 2025 13:04
Signed-off-by: surya4419 <suryaa4419@gmail.com>
@surya4419
Copy link
Contributor Author

@surya4419 can you check the failing tests?

I have fixed the failing tests in my PR. Could you please review it when you have time? Let me know if any further changes are needed

…n selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you just fix the merge conflict?

@surya4419
Copy link
Contributor Author

Looks good! Can you just fix the merge conflict?

I’ve fixed the merge conflict. Please review and merge my PR when you get a chance. Thanks!

@DianaLease DianaLease merged commit 6061877 into accordproject:main Mar 26, 2025
7 checks passed
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 26, 2025
…dproject#174)

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 26, 2025
…dproject#174)

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 26, 2025
…dproject#174)

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navbar Responsiveness Issue – Menu Items Not Collapsing on Smaller Screens

2 participants