fix(navbar): improve responsiveness for better user experience#174
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DianaLease
left a comment
There was a problem hiding this comment.
Do we need the "explore" button on smaller screens? It scrolls to the footer in desktop view but the footer is removed in smaller views so it seems like that button shouldn't be shown when the footer is removed.
|
Thanks for the feedback! @DianaLease However, I noticed that another recent PR(#190 ) added the footer back on smaller screens. Since the footer is now present, the "Explore" button remains relevant. |
|
@DianaLease Thanks for your feedback earlier! Since PR #190 has now been successfully merged, the footer is back on smaller screens, making the "Explore" button still relevant. Given this update, could you please review my PR again and let me know if any further changes are needed? |
That makes sense, can you update your branch with the latest main and resolve conflicts so that we can test that it's working with the latest changes? Thanks! |
5486f2b to
969804e
Compare
|
@DianaLease , I have updated my branch with the latest main and resolved all conflicts. Everything should be good to go for testing now. Let me know if you need any further changes. Thanks! |
DianaLease
left a comment
There was a problem hiding this comment.
Is there a reason you removed the animation from the "Learn" button? If not, can you add that back?
969804e to
1546518
Compare
I’ve re-added the animation for the 'Learn' button. Please take a look at my PR when you get a chance. Let me know if any further adjustments are needed!" |
d675ed7 to
9605546
Compare
|
@DianaLease could you please review my PR again. |
|
@surya4419 can you check the failing tests? |
Signed-off-by: surya4419 <suryaa4419@gmail.com>
9605546 to
3704f86
Compare
Signed-off-by: surya4419 <suryaa4419@gmail.com>
I have fixed the failing tests in my PR. Could you please review it when you have time? Let me know if any further changes are needed |
…n selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com>
DianaLease
left a comment
There was a problem hiding this comment.
Looks good! Can you just fix the merge conflict?
I’ve fixed the merge conflict. Please review and merge my PR when you get a chance. Thanks! |
…dproject#174) * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
…dproject#174) * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com> Signed-off-by: Dharma Teja <dteja2468@gmail.com>
…dproject#174) * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com> Signed-off-by: Dharma Teja <dteja2468@gmail.com>
The navbar was not responsive on smaller screens, causing layout issues.
This update ensures the navbar adapts properly across different screen sizes
by implementing a more flexible design.
Refs: #172
Closes #172
Changes
Flags
Screenshots or Video
Before Changes


After Changes

Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname