fix: dark mode persistence on Learn page#183
Merged
DianaLease merged 6 commits intoaccordproject:mainfrom Mar 13, 2025
yashsaraswat2004:yashsaraswat/i182/dark-mode-fix
Merged
fix: dark mode persistence on Learn page#183DianaLease merged 6 commits intoaccordproject:mainfrom yashsaraswat2004:yashsaraswat/i182/dark-mode-fix
DianaLease merged 6 commits intoaccordproject:mainfrom
yashsaraswat2004:yashsaraswat/i182/dark-mode-fix
Conversation
Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
- Add mobile-first responsive navbar - Preserve help dropdown functionality - Optimize logo/text hierarchy Closes #172 Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
@yashsaraswat2004 I think you should add classic white boundary design also which is used on home page for consistancy |
Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
DianaLease
requested changes
Mar 7, 2025
Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
Contributor
Author
|
Hey @DianaLease . I've made the requested changes: removed console.log statements and reverted unrelated navbar modifications. Let me know if any further tweaks are needed. Thanks for the review! |
Member
Thanks! Can you merge the latest main into your branch? |
Contributor
Author
|
I have merged the latest main into my branch. Thanks @DianaLease!" |
DianaLease
approved these changes
Mar 13, 2025
Member
|
Thanks for the contribution! |
teja-pola
pushed a commit
to teja-pola/template-playground
that referenced
this pull request
Mar 13, 2025
* fix(navbar): implement responsive collapse at 955px Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix(navbar): implement responsive collapse at 955px - Add mobile-first responsive navbar - Preserve help dropdown functionality - Optimize logo/text hierarchy Closes accordproject#172 Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: dark mode persistence on Learn page Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * feat: add additional style changes for Learn page consistency Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: remove console.log and revert unrelated navbar changes Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> --------- Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 14, 2025
* fix(navbar): implement responsive collapse at 955px Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix(navbar): implement responsive collapse at 955px - Add mobile-first responsive navbar - Preserve help dropdown functionality - Optimize logo/text hierarchy Closes accordproject#172 Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: dark mode persistence on Learn page Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * feat: add additional style changes for Learn page consistency Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: remove console.log and revert unrelated navbar changes Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> --------- Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 14, 2025
* fix(navbar): implement responsive collapse at 955px Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix(navbar): implement responsive collapse at 955px - Add mobile-first responsive navbar - Preserve help dropdown functionality - Optimize logo/text hierarchy Closes accordproject#172 Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: dark mode persistence on Learn page Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * feat: add additional style changes for Learn page consistency Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: remove console.log and revert unrelated navbar changes Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> --------- Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 14, 2025
* fix(navbar): implement responsive collapse at 955px Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix(navbar): implement responsive collapse at 955px - Add mobile-first responsive navbar - Preserve help dropdown functionality - Optimize logo/text hierarchy Closes accordproject#172 Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: dark mode persistence on Learn page Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * feat: add additional style changes for Learn page consistency Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> * fix: remove console.log and revert unrelated navbar changes Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> --------- Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com> Signed-off-by: surya4419 <suryaa4419@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #182 the dark mode persistence issue on the Learn page. The theme now persists across page navigation and reloads.
Changes
localStorage.data-themeattribute.Related Issue
Screenshots
Before
](https://private-user-images.githubusercontent.com/117703874/419933578-9d2d4b96-f3fa-4c37-acee-3905fe29ceb7.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMxMTA4ODEsIm5iZiI6MTc3MzExMDU4MSwicGF0aCI6Ii8xMTc3MDM4NzQvNDE5OTMzNTc4LTlkMmQ0Yjk2LWYzZmEtNGMzNy1hY2VlLTM5MDVmZTI5Y2ViNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMzEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDMxMFQwMjQzMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mNWUzOWJiNDdhNzEyNzA3YmEzNjkwYTAxY2FlZmQ1NTUwNTYzMmRhMzFkNGQ1MzYxZjNiOTk2MzU0MzM5ZjRmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.VPwSUlR3QRdZs_PCKuGy73p1ooYoZJX8WOP6t1kWV8I)
)
After
](https://private-user-images.githubusercontent.com/117703874/419933299-251582d6-d141-4a3b-999e-1285620460c6.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzMxMTA4ODEsIm5iZiI6MTc3MzExMDU4MSwicGF0aCI6Ii8xMTc3MDM4NzQvNDE5OTMzMjk5LTI1MTU4MmQ2LWQxNDEtNGEzYi05OTllLTEyODU2MjA0NjBjNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMzEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDMxMFQwMjQzMDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03YmMyM2JiZDdhMjYyZjc3ZTM0YTgyN2E3ZGU1OGIwYTg5OWJiYmRjYzg2NDZlYjU3ZDc0M2U1NWVmMjdlNTQwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0yZtHm0UDW046XO2FJofvmOQa1HBBUzCSkh9FY4EXcc)
)
Checklist
localStorage.Notes for Reviewers