Skip to content

fix: resolve ESLint and TypeScript type declaration issues in multiple files#195

Merged
DianaLease merged 1 commit intoaccordproject:mainfrom
yashsaraswat2004:yash/i186/eslint-ts-fix
Mar 17, 2025
Merged

fix: resolve ESLint and TypeScript type declaration issues in multiple files#195
DianaLease merged 1 commit intoaccordproject:mainfrom
yashsaraswat2004:yash/i186/eslint-ts-fix

Conversation

@yashsaraswat2004
Copy link
Contributor

Related to #186

This PR resolves ESLint errors and TypeScript type declaration inconsistencies across multiple files to improve code quality, maintainability, and developer experience.

Changes

  • Fixed ESLint errors in Sidebar.tsx, FullScreenModal.tsx, Navbar.tsx, ToggleDarkMode.tsx, App.tsx, ConcertoEditor.tsx, MarkDownEditor.tsx, and AgreementHTML.tsx.
  • Resolved TypeScript type inconsistencies, missing types, and improper type assertions in the above files.
  • Ensured all files adhere to the configured ESLint rules and TypeScript type safety standards.

Flags

  • Some files required significant refactoring to resolve TypeScript type issues.
  • ESLint rules were strictly enforced, which may require additional review to ensure no unintended side effects.

Screenshots or Video

N/A (No UI changes were made; this PR focuses on code quality improvements.)

Related Issues

@yashsaraswat2004 yashsaraswat2004 requested a review from a team as a code owner March 7, 2025 13:03
@netlify
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 0455d2f
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67d483abd9de230008441e50
😎 Deploy Preview https://deploy-preview-195--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yashsaraswat2004 yashsaraswat2004 changed the title fix: resolve ESLint and TypeScript type declaration issues in multiple files #186 fix: resolve ESLint and TypeScript type declaration issues in multiple files Mar 7, 2025
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment. Please also resolve merge conflicts.

Open the
<Link to="/" target="_blank" rel="noopener noreferrer">
Template Playground
</Link>{" "}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change affected the white space in the text here. Please fix.
Screenshot 2025-03-13 at 5 18 53 PM

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
@yashsaraswat2004
Copy link
Contributor Author

@DianaLease I have resolved the conflicts. Can you review it now .!!

@DianaLease DianaLease merged commit 4acb5e9 into accordproject:main Mar 17, 2025
7 checks passed
surya4419 pushed a commit to surya4419/template-playground that referenced this pull request Mar 17, 2025
…oject#195)

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
surya4419 pushed a commit to surya4419/template-playground that referenced this pull request Mar 17, 2025
…oject#195)

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 18, 2025
…oject#195)

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
codeAntu pushed a commit to codeAntu/template-playground that referenced this pull request Mar 18, 2025
…oject#195)

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
Signed-off-by: Ananta <codeantu@gmail.com>
codeAntu pushed a commit to codeAntu/template-playground that referenced this pull request Mar 18, 2025
…oject#195)

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
surya4419 pushed a commit to surya4419/template-playground that referenced this pull request Mar 19, 2025
…oject#195)

Signed-off-by: Yashsaraswat2004 <saraswatyash2004@gmail.com>
Signed-off-by: surya4419 <suryaa4419@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants