fix(ui): add proper margin to error notification for consistent spacing#256
Merged
DianaLease merged 2 commits intoaccordproject:mainfrom Mar 27, 2025
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
surya4419
force-pushed
the
surya4419/i255/error-notification-Lacks-Proper-Margin
branch
from
54ff88e to
a44e558
Compare
Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
force-pushed
the
surya4419/i255/error-notification-Lacks-Proper-Margin
branch
from
cc7a3e7 to
832795c
Compare
…cordproject#281) * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
Contributor
Author
|
Hi @DianaLease ,When you have some free time, could you please review my PR? |
DianaLease
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #255
This PR fixes the issue where the error notification lacked proper margins, causing UI inconsistencies.
It ensures that the notification is spaced correctly by wrapping it inside an Ant Design
<Space>component.Changes
<Space>component.margin: "24px 0 0 24px") to maintain UI consistency.Screenshots or Video
(Attach screenshots or a short video demonstrating the fix)
Before Changes
After Changes
Related Issues
Issue Error Notification Lacks Proper Margin and Causes UI Clutter #255
Author Checklist
--signoffoption of git commit.mainfromfork:branchname, add info.