fix(prevent-full-reload): by changing a tag with Link tag (#i258)#259
Merged
DianaLease merged 5 commits intoaccordproject:mainfrom Mar 17, 2025
sahilkhan117:sahilkhan117/i258/fix-prevent-full-reloading
Merged
fix(prevent-full-reload): by changing a tag with Link tag (#i258)#259DianaLease merged 5 commits intoaccordproject:mainfrom sahilkhan117:sahilkhan117/i258/fix-prevent-full-reloading
DianaLease merged 5 commits intoaccordproject:mainfrom
sahilkhan117:sahilkhan117/i258/fix-prevent-full-reloading
Conversation
…oading (#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
…oading (#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
…//github.com/sahilkhan117/template-playground-By-Accord-Project into sahilkhan117/i258/fix-prevent-full-reloading
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@DianaLease please review my PR and Let me know if there is any changes or corrections regarding this problem. |
DianaLease
approved these changes
Mar 17, 2025
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 17, 2025
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> --------- Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 17, 2025
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> --------- Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 17, 2025
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> --------- Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
surya4419
pushed a commit
to surya4419/template-playground
that referenced
this pull request
Mar 17, 2025
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> --------- Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola
pushed a commit
to teja-pola/template-playground
that referenced
this pull request
Mar 18, 2025
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> --------- Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com>
codeAntu
pushed a commit
to codeAntu/template-playground
that referenced
this pull request
Mar 18, 2025
…cordproject#259) * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#250) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): Replace <a> tag with <Link> tag to prevent full reloading (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> * fix(full-reload): rel attribute is unnecessary for internal links (accordproject#258) Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> --------- Signed-off-by: Sahil Khan <sahilkhan123098p@gmail.com> Signed-off-by: Ananta <codeantu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258
This PR fixes the issue where clicking the logo caused a full page reload instead of a smooth React Router navigation.
Summary
This pull request addresses the issue where clicking the logo caused a full page reload. By replacing the
<a href="/">element with<Link to="/">fromreact-router-dom, the navigation is now handled smoothly without reloading the page, preserving the React state and ensuring a better user experience.@DianaLease please review my PR and Let me know if there is any changes or corrections regarding this problem.
Changes
<a href="/">with<Link to="/">fromreact-router-dom.New Code
Flags
Resolved Problem Video Demo
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:sahilkhan117/i258/fix-logo-reload.