feat(editor): Add auto-pairing for curly braces in Concerto model #281
Merged
DianaLease merged 3 commits intoaccordproject:mainfrom Mar 27, 2025
Conversation
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Hey @DianaLease , when you have some time, could you please review my PR? I'd love to get your feedback. Thanks! |
sanketshevkar
approved these changes
Mar 17, 2025
Member
sanketshevkar
left a comment
sanketshevkar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution. Can you please rebase your branch?
surya4419
force-pushed
the
surya4419/i280/Auto-Pairing-Curly-Braces-in-Concerto-Model
branch
from
1cfc302 to
0b28208
Compare
Contributor
Author
|
You're welcome! I've rebased my branch as requested. Please review my PR when you get a chance and let me know if any further changes are needed.
You're welcome! @sanketshevkar I've rebased my branch as requested. Please review my PR when you get a chance and let me know if any further changes are needed. |
surya4419
force-pushed
the
surya4419/i280/Auto-Pairing-Curly-Braces-in-Concerto-Model
branch
from
0b28208 to
0d95a91
Compare
Contributor
Author
|
@sanketshevkar Thank you for reviewing my PR! Since you've approved my changes, could you please merge it when you get a chance? |
Member
|
@surya4419 Can you fix the merge conflict? thank you! |
Contributor
Author
I’ve fixed the merge conflict. Please review and merge my PR when you get a chance. Thanks! |
…tion Signed-off-by: surya4419 <suryaa4419@gmail.com>
…tion Signed-off-by: surya4419 <suryaa4419@gmail.com>
…tion Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
force-pushed
the
surya4419/i280/Auto-Pairing-Curly-Braces-in-Concerto-Model
branch
from
b155cee to
9230ad2
Compare
surya4419
deleted the
surya4419/i280/Auto-Pairing-Curly-Braces-in-Concerto-Model
branch
surya4419
added a commit
to surya4419/template-playground
that referenced
this pull request
Mar 27, 2025
…cordproject#281) * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
added a commit
to surya4419/template-playground
that referenced
this pull request
Mar 27, 2025
…cordproject#281) * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
DianaLease
pushed a commit
that referenced
this pull request
Mar 27, 2025
…ng (#256) * fix(ui): add proper margin to error notification for consistent spacing Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model (#281) * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
sanketshevkar
pushed a commit
that referenced
this pull request
Mar 29, 2025
* feat(editor): add resizable editor/preview panes for improved flexibility Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model (#281) * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): Add auto-pairing for curly braces in Concerto model section Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com> * feat(editor): add resizable editor/preview panes for improved flexibility Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280
This PR adds an automatic pairing feature for curly braces {} in the Concerto model section within the Monaco Editor. This improves the editing experience by reducing syntax errors and ensuring balanced brace structures.
Changes
Screenshots or Video
After Changes
Template.Playground.-.Google.Chrome.2025-03-17.20-11-25.mp4
Related Issues
Author Checklist
it-works) for your commits using the
--signoffoption of git commit.mainfromfork:branchname