Skip to content

fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection#318

Merged
DianaLease merged 1 commit intoaccordproject:mainfrom
surya4419:surya4419/i317/Samples-Dropdown-Not-Updating-All-Sections
Mar 24, 2025
Merged

fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection#318
DianaLease merged 1 commit intoaccordproject:mainfrom
surya4419:surya4419/i317/Samples-Dropdown-Not-Updating-All-Sections

Conversation

@surya4419
Copy link
Contributor

Closes #317

This PR fixes the issue where selecting a sample from the dropdown did not update the TemplateMark, Concerto Model, and Preview Data sections. The problem was caused by improper state synchronization in the useUndoRedo hook.

Changes

  • Updated useUndoRedo hook to properly handle initialValue updates from the store.
  • Added a useEffect to ensure the editor state resets and updates correctly when a new sample is selected.
  • Ensured that changes propagate to all dependent components.

Screenshots or Video

Template.Playground.-.Google.Chrome.2025-03-22.11-46-48.mp4

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests.
  • Commit messages follow AP format.
  • Extend the documentation, if necessary.
  • Merging to main from fork:branchname.

…n selection

Signed-off-by: surya4419 <suryaa4419@gmail.com>
@surya4419 surya4419 requested a review from a team as a code owner March 22, 2025 06:20
@netlify
Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 198815c
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/67de569add868e0008ea0c3f
😎 Deploy Preview https://deploy-preview-318--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surya4419
Copy link
Contributor Author

@DianaLease @sanketshevkar , Could you review my PR? It fixes state sync issues in useUndoRedo, ensuring TemplateMark, Concerto Model, and Preview Data update when selecting a sample. Let me know if you have any feedback!

@DianaLease DianaLease merged commit 0ba6343 into accordproject:main Mar 24, 2025
7 checks passed
surya4419 added a commit to surya4419/template-playground that referenced this pull request Mar 24, 2025
…n selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419 added a commit to surya4419/template-playground that referenced this pull request Mar 24, 2025
…n selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419 added a commit to surya4419/template-playground that referenced this pull request Mar 24, 2025
…n selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419 added a commit to surya4419/template-playground that referenced this pull request Mar 24, 2025
…n selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>
@surya4419 surya4419 deleted the surya4419/i317/Samples-Dropdown-Not-Updating-All-Sections branch March 25, 2025 03:50
DianaLease pushed a commit that referenced this pull request Mar 26, 2025
* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 26, 2025
…dproject#174)

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 26, 2025
…dproject#174)

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
teja-pola pushed a commit to teja-pola/template-playground that referenced this pull request Mar 26, 2025
…dproject#174)

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(navbar): improve responsiveness for better user experience

Signed-off-by: surya4419 <suryaa4419@gmail.com>

* fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318)

Signed-off-by: surya4419 <suryaa4419@gmail.com>

---------

Signed-off-by: surya4419 <suryaa4419@gmail.com>
Signed-off-by: Dharma Teja <dteja2468@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Samples Dropdown Selection Does Not Update TemplateMark, Concerto Model, and Preview Data

2 participants