fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection#318
Merged
DianaLease merged 1 commit intoaccordproject:mainfrom Mar 24, 2025
Conversation
…n selection Signed-off-by: surya4419 <suryaa4419@gmail.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
@DianaLease @sanketshevkar , Could you review my PR? It fixes state sync issues in useUndoRedo, ensuring TemplateMark, Concerto Model, and Preview Data update when selecting a sample. Let me know if you have any feedback! |
DianaLease
approved these changes
Mar 24, 2025
surya4419
added a commit
to surya4419/template-playground
that referenced
this pull request
Mar 24, 2025
…n selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
added a commit
to surya4419/template-playground
that referenced
this pull request
Mar 24, 2025
…n selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
added a commit
to surya4419/template-playground
that referenced
this pull request
Mar 24, 2025
…n selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com>
surya4419
added a commit
to surya4419/template-playground
that referenced
this pull request
Mar 24, 2025
…n selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com>
DianaLease
pushed a commit
that referenced
this pull request
Mar 26, 2025
* fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola
pushed a commit
to teja-pola/template-playground
that referenced
this pull request
Mar 26, 2025
…dproject#174) * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com>
teja-pola
pushed a commit
to teja-pola/template-playground
that referenced
this pull request
Mar 26, 2025
…dproject#174) * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com> Signed-off-by: Dharma Teja <dteja2468@gmail.com>
teja-pola
pushed a commit
to teja-pola/template-playground
that referenced
this pull request
Mar 26, 2025
…dproject#174) * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(navbar): improve responsiveness for better user experience Signed-off-by: surya4419 <suryaa4419@gmail.com> * fix(samples): update TemplateMark, Concerto Model, and Preview Data on selection (accordproject#318) Signed-off-by: surya4419 <suryaa4419@gmail.com> --------- Signed-off-by: surya4419 <suryaa4419@gmail.com> Signed-off-by: Dharma Teja <dteja2468@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
This PR fixes the issue where selecting a sample from the dropdown did not update the TemplateMark, Concerto Model, and Preview Data sections. The problem was caused by improper state synchronization in the
useUndoRedohook.Changes
useUndoRedohook to properly handleinitialValueupdates from the store.useEffectto ensure the editor state resets and updates correctly when a new sample is selected.Screenshots or Video
Template.Playground.-.Google.Chrome.2025-03-22.11-46-48.mp4
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname.