fix: add type definitions, extract hook, and implement security harde… #705
+121
−83
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { useState } from 'react'; | ||
| import * as monaco from 'monaco-editor'; | ||
| import useAppStore from '../store/store'; | ||
| import CodeSelectionMenu from '../components/CodeSelectionMenu'; | ||
|
|
||
| export const useCodeSelection = (editorType: 'markdown' | 'concerto' | 'json') => { | ||
| const [selectedText, setSelectedText] = useState(''); | ||
| const [menuPosition, setMenuPosition] = useState<{ x: number; y: number } | null>(null); | ||
| const [showMenu, setShowMenu] = useState(false); | ||
| const enableCodeSelectionMenu = useAppStore((state) => state.aiConfig?.enableCodeSelectionMenu ?? true); | ||
|
|
||
|
|
||
| const handleSelection = (editor: monaco.editor.IStandaloneCodeEditor) => { | ||
| const selection = editor.getSelection(); | ||
| if (selection && !selection.isEmpty()) { | ||
| const selectedText = editor.getModel()?.getValueInRange(selection).trim(); | ||
| if (selectedText && selectedText.length > 0) { | ||
| const position = editor.getScrolledVisiblePosition(selection.getStartPosition()); | ||
| const editorContainer = editor.getDomNode()?.closest('.editorwrapper'); | ||
| const editorRect = editorContainer?.getBoundingClientRect(); | ||
|
|
||
| let x: number, y: number; | ||
|
|
||
| if (editorRect && position) { | ||
| x = Math.max(editorRect.left + 20, Math.min(position.left, editorRect.right - 150)); | ||
| y = Math.max(editorRect.top + 20, Math.min(position.top, editorRect.bottom - 50)); | ||
|
|
||
| x = Math.max(10, Math.min(x, window.innerWidth - 150)); | ||
| y = Math.max(10, Math.min(y, window.innerHeight - 50)); | ||
| } else if (position) { | ||
| x = Math.max(10, Math.min(position.left, window.innerWidth - 150)); | ||
| y = Math.max(10, Math.min(position.top, window.innerHeight - 50)); | ||
| } else { | ||
| return; | ||
| } | ||
|
|
||
| setSelectedText(selectedText); | ||
| setMenuPosition({ | ||
| x: x, | ||
| y: y | ||
| }); | ||
| setShowMenu(true); | ||
| } | ||
| } else { | ||
| setShowMenu(false); | ||
| } | ||
| } | ||
|
|
||
| const closeMenu = () => { | ||
| setShowMenu(false); | ||
| setSelectedText(''); | ||
| setMenuPosition(null); | ||
| }; | ||
|
|
||
| const MenuComponent = (enableCodeSelectionMenu && showMenu && selectedText && menuPosition) ? ( | ||
| <CodeSelectionMenu | ||
| selectedText={selectedText} | ||
| position={menuPosition} | ||
| onClose={closeMenu} | ||
| editorType={editorType} | ||
| /> | ||
| ) : null; | ||
|
||
|
|
||
| return { | ||
| handleSelection, | ||
| closeMenu, | ||
| MenuComponent | ||
| }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
There was a problem hiding this comment. We should move typescript typedef upstream to the @accordproject/markdown-template package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| declare module '@accordproject/markdown-template' { | ||
| import { ModelManager } from '@accordproject/concerto-core'; | ||
|
|
||
| export class TemplateMarkTransformer { | ||
| fromMarkdownTemplate(options: { | ||
| fileName: string; | ||
| content: string; | ||
| modelManager: ModelManager; | ||
| templateKind?: string; | ||
| }): { getModelManager: () => ModelManager }; | ||
|
|
||
| toMarkdownTemplate(parserManager: { getModelManager: () => ModelManager }): string; | ||
|
|
||
| generate(data: Record<string, unknown>, parserManager: { getModelManager: () => ModelManager }): string; | ||
|
|
||
| getVariables(parserManager: { getModelManager: () => ModelManager }): Record<string, unknown>; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.