Feat: implemented Share Modal UI for improved UX#747
Open
LaveUI wants to merge 9 commits intoaccordproject:mainfrom
Open
Feat: implemented Share Modal UI for improved UX#747LaveUI wants to merge 9 commits intoaccordproject:mainfrom
LaveUI wants to merge 9 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: LaveUI <vaibhavgupta1612@gmail.com>
❌ Deploy Preview for ap-template-playground failed.
|
Signed-off-by: LaveUI <vaibhavgupta1612@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated Share modal workflow to the Template Playground so users can view/copy the generated share URL and access quick social-share actions, instead of silently copying a long link on click.
Changes:
- Introduces a new
ShareModalcomponent and renders it fromPlaygroundSidebar. - Updates Share triggers (
PlaygroundSidebar,UseShare) to open the modal via Zustand state (isShareModalOpen). - Updates existing unit/e2e tests to reflect the modal-based share flow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/components/PlaygroundSidebar.test.tsx | Mocks and asserts presence of the new Share modal in the sidebar test setup. |
| src/store/store.ts | Adds global Zustand state to control Share modal visibility. |
| src/components/UseShare.tsx | Replaces direct clipboard-copy behavior with opening the Share modal. |
| src/components/ShareModal.tsx | New modal UI for share URL display/copy and social-share actions. |
| src/components/PlaygroundSidebar.tsx | Wires “Share” nav item to open the Share modal and renders the modal. |
| e2e/share.spec.ts | Updates Playwright flows to copy from within the modal and validate the shared URL. |
Contributor
Author
|
Sure @mttrbrts , I'll remove the social sharing options and keep it limited to generating and copying the sharable link |
Signed-off-by: LaveUI <vaibhavgupta1612@gmail.com>
Signed-off-by: LaveUI <vaibhavgupta1612@gmail.com>
Signed-off-by: LaveUI <vaibhavgupta1612@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, clicking the "Share" button in the template playground silently copies a very long URL to the clipboard. While functional, it lacks a standard, accessible UI for users to see the link or share it easily to other platforms.
Solution
This PR introduces a dedicated [ShareModal] component that triggers when a user clicks "Share".
Copied!).useAppStorefor easy access across the app.Testing