fix(preview): show error in preview when template processing fails#777
Open
harsh-na wants to merge 1 commit intoaccordproject:mainfrom
Open
fix(preview): show error in preview when template processing fails#777harsh-na wants to merge 1 commit intoaccordproject:mainfrom
harsh-na wants to merge 1 commit intoaccordproject:mainfrom
Conversation
Signed-off-by: harshit <harshitgalaxy710@gmail.com>
✅ Deploy Preview for ap-template-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
@mttrbrts , I checked the logs, the reason is due to duplication of locator in Playwright Script. With ref. to my current feature branch I did the neccessary changes, which may segrgate the duplicate locators, still problem persists, I simply switch to main branch and run the tests, there also they are failing, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(preview): prevent stale agreement HTML from rendering when processing errors occur
Closes #774
This PR ensures that the Preview panel reflects the actual processing state of the template. Previously, when an error occurred during template/model/data processing, the Preview continued showing the last successfully generated agreement HTML, which created inconsistency between the editor state and the rendered output.
With this change, the Preview now displays the corresponding error message instead of stale content whenever a rebuild fails.
Changes
agreementErrorstate to the global store to track processing errors.Flags
Screenshots or Video
Previously I make some error, I only get the issue in Problem Panel

Now we are getting in the Preview Panel as well, which gives correct user experience
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname