feat(aiconfig): added predefined ai models by hemantch01 · Pull Request #781 · accordproject/template-playground

hemantch01 · 2026-03-07T11:10:35Z

Closes #780

This PR improves the AI configuration UX by replacing the free-text model input with a provider-aware dropdown. It suggests popular models for each provider and includes a Custom option for manual entry when needed. This helps reduce errors caused by typos or incorrect model names.

Changes

Added a PROVIDER_MODELS constant with curated model lists for supported providers.
Replaced the model text input with a provider-based dropdown in AIConfigPopup.
Added a Custom option that shows a manual input field when selected.
Reset the model selection when the provider changes.
Restored custom models from localStorage if the saved model is not in the provider list.
Added unit tests for providerModels and the model selection behavior in AIConfigPopup.

Flags

For OpenAI-compatible APIs, the model field remains a text input because models can be user-defined.
Existing Ollama help text and warnings remain unchanged.

Screenshots or Video

Test Results

Related Issues

Issue Enhancements: Add Predefined models in ai-chat Instead of Input Box #780

Author Checklist

Ensure you provide a DCO sign-off for your commits using the --signoff option
Vital features and changes captured in unit and/or integration tests
Commit messages follow AP format
Extend the documentation, if necessary

netlify · 2026-03-07T11:10:40Z

✅ Deploy Preview for ap-template-playground ready!

Name	Link
🔨 Latest commit	`a001b79`
🔍 Latest deploy log	https://app.netlify.com/projects/ap-template-playground/deploys/69ada6ce142cf20008d89566
😎 Deploy Preview	https://deploy-preview-781--ap-template-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This PR improves the AI Configuration popup by introducing provider-aware, curated model selection (with a Custom fallback), reducing user error from manual model-name typing.

Changes:

Added PROVIDER_MODELS + getModelsForProvider to centralize curated model options per provider.
Updated AIConfigPopup to use a provider-based model dropdown (with “Custom…” to reveal a text input) and to reset model state on provider change.
Added unit tests for providerModels and the model-selection UI behavior; updated several dependencies in package.json.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/components/AIConfigPopup.tsx	Replaces free-text model entry with provider-aware dropdown + custom model flow; resets model on provider change; restores custom models from localStorage.
src/ai-assistant/providerModels.ts	Introduces curated provider → model option lists and a helper accessor.
src/tests/components/AIConfigPopupModelSelect.test.tsx	Adds UI tests for provider/model selection behavior (dropdown, provider switch reset, custom option, openai-compatible text input).
src/tests/ai-assistant/providerModels.test.ts	Adds unit tests validating provider model lists and `getModelsForProvider` behavior.
package.json	Upgrades multiple dependencies (Accord Project packages + react-router-dom).

Copilot · 2026-03-07T17:50:37Z

src/components/AIConfigPopup.tsx

-      if (savedModel) setModel(savedModel);
+      if (savedModel) {
+        setModel(savedModel);
+        // checking if saved model is in the provider's lis — if not, it's custom


There’s a typo in the comment: “provider's lis” should be “provider's list”.

Suggested change

// checking if saved model is in the provider's lis — if not, it's custom

// checking if saved model is in the provider's list — if not, it's custom

Copilot · 2026-03-07T17:50:37Z

src/components/AIConfigPopup.tsx

+            {provider === 'ollama' && (
+              <div className={`mt-1 text-xs ${theme.helpText}`}>
+                <span className="text-orange-500 font-bold">
+                  ⚠️ Must run: <code>OLLAMA_ORIGINS="*" ollama serve</code>
+                </span>
              </div>


The PR description says the existing Ollama help text/warnings are unchanged, but this UI now only shows the serve command and no longer includes the example model list that was previously shown. Either restore the removed Ollama help text or update the PR description to match the new behavior.

Copilot · 2026-03-07T17:50:37Z

src/tests/components/AIConfigPopupModelSelect.test.tsx

+    it('should show Custom option and text input when Custom is selected', () => {
+        render(<AIConfigPopup isOpen={true} onClose={mockOnClose} onSave={mockOnSave} />);
+
+        const providerSelect = screen.getByDisplayValue('Select a provider');
+        fireEvent.change(providerSelect, { target: { value: 'openai' } });
+
+        // Select "Custom..."
+        const modelSelect = screen.getByDisplayValue('Select a model');
+        fireEvent.change(modelSelect, { target: { value: '__custom__' } });
+
+        // Custom text input should appear
+        expect(screen.getByPlaceholderText('Enter custom model name')).toBeInTheDocument();
+    });


Tests cover switching providers and selecting “Custom…”, but there’s no test for the new behavior that restores a saved custom model from localStorage when it isn’t in the provider’s curated list. Add a test that seeds localStorage with provider + an unknown model value, renders the popup, and asserts the Custom input is shown and prefilled.

Copilot · 2026-03-07T17:50:38Z

package.json

+    "@accordproject/concerto-core": "^3.25.7",
+    "@accordproject/markdown-common": "^0.17.2",
+    "@accordproject/markdown-template": "^0.17.2",
+    "@accordproject/markdown-transform": "^0.17.2",
+    "@accordproject/template-engine": "^2.7.1",


This PR description focuses on the model dropdown UX, but package.json also upgrades multiple core Accord Project dependencies. Please either add rationale/impact notes in the PR description (and any required follow-up changes) or split dependency upgrades into a separate PR to keep the review surface focused.

Copilot · 2026-03-07T17:50:38Z

package.json

    "react-markdown": "^9.0.1",
    "react-resizable-panels": "^3.0.3",
-    "react-router-dom": "^6.24.1",
+    "react-router-dom": "^6.30.2",


react-router-dom is also upgraded in this PR but isn’t mentioned in the PR description. Please document why this upgrade is needed here (or move it to a dedicated dependency update PR) since it can have runtime/router behavior changes.

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

sanketshevkar

Can you please explore an open-source library that is well-maintained and is constantly updated with the model list.

I don't think we should maintain this list here in the project. Things are moving very fast, its hard to be on top of this and keep this updated.

hemantch01 · 2026-03-09T11:00:36Z

hi @sanketshevkar there is no dedicated library for this..... but i have a approach, we can create a public repo (like ai-model-regitstry) and then create a json file, and then we can just fetch from the url like https://raw.githubusercontent.com/username/ai-model-registry/*.json Or should i look for any other library??

hemantch01 requested a review from a team as a code owner March 7, 2026 11:10

hemantch01 force-pushed the Enhancement/added_predefined_models branch from 01f64f4 to 7eec485 Compare March 7, 2026 11:18

mttrbrts requested a review from Copilot March 7, 2026 17:47

Copilot started reviewing on behalf of mttrbrts March 7, 2026 17:47 View session

mttrbrts changed the title ~~Enhancement/added predefined models~~ feat(aiconfig): added predefined ai models Mar 7, 2026

Copilot AI reviewed Mar 7, 2026

View reviewed changes

hemantch01 added 5 commits March 8, 2026 16:03

feat:add provider models constant with curated model lists

2ec4363

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

replace model input with provider-aware select dropdown

bee2684

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

add unit tests for providerModels

a04b927

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

tests ran successfully

69af75a

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

added gemini 3 models

0e36c4b

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

hemantch01 force-pushed the Enhancement/added_predefined_models branch from 66f0dd9 to 0e36c4b Compare March 8, 2026 16:22

fix: remove invalid onSave from model select tests

a001b79

Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>

hemantch01 force-pushed the Enhancement/added_predefined_models branch from 2a102d9 to a001b79 Compare March 8, 2026 16:41

sanketshevkar requested changes Mar 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(aiconfig): added predefined ai models#781

feat(aiconfig): added predefined ai models#781
hemantch01 wants to merge 6 commits intoaccordproject:mainfrom
hemantch01:Enhancement/added_predefined_models

hemantch01 commented Mar 7, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

Copilot AI Mar 7, 2026

Uh oh!

sanketshevkar left a comment

Uh oh!

hemantch01 commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// checking if saved model is in the provider's lis — if not, it's custom
	// checking if saved model is in the provider's list — if not, it's custom

Uh oh!

Conversation

hemantch01 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Closes #780

Changes

Flags

Screenshots or Video

Test Results

Related Issues

Author Checklist

Uh oh!

netlify bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for ap-template-playground ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

sanketshevkar left a comment

Choose a reason for hiding this comment

Uh oh!

hemantch01 commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hemantch01 commented Mar 7, 2026 •

edited

Loading

netlify bot commented Mar 7, 2026 •

edited

Loading