Workaround for CPU spin on NamedPipeClientStream.Connect() #13
+48
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d without a timeout
|
This is a really useful library, it would be great to get an updated nuget package available with a workaround to this unexpected CPU spin behaviour. |
jameswestgate
added a commit
to jameswestgate/named-pipe-wrapper
that referenced
this pull request
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates a portion of work implemented in another pull request by @darvell. Specifically commit 257d1a4 in pull request #3
This change simply also catches TimeoutException's, moves the PInvoke to another class and uses the correct variable names and data types for the WaitNamedPipe() arguments.