Skip to content

Interaction - Fix no inventory interaction in ragdoll state #10783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • title.

Related to #10436.

@Dystopian Dystopian changed the title Fix no inventory interaction in ragdoll state Interaction - Fix no inventory interaction in ragdoll state Mar 8, 2025
@LinkIsGrim LinkIsGrim self-requested a review March 14, 2025 11:23
@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Mar 14, 2025
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Mar 14, 2025
@johnb432
Copy link
Contributor

johnb432 commented Mar 16, 2025

I don't understand why we need to add this, can you please elaborate?

If it's because of

Since recent Arma changes this state is not considered with lifeState command as it was before. So we need additional isAwake check.

you need to give detailed steps on how to reproduce that, because I can't.

@Dystopian
Copy link
Contributor Author

As you said here #10436 (comment)

Imo the better solution is to either add individual checks where it's necessary

This PR fixes missing Inventory interaction only for unit in ragdoll state instead of #10436.

Repro:

  1. place 2 units, start
  2. aim at the 2nd unit, run cursorObject addForce [vectorDir cursorObject vectorMultiply 1000, cursorObject selectionPosition "SPINE", false]
  3. interact with the fallen unit, see no Inventory action
  4. kill the 2nd unit, interact with body, see Inventory action

It worked as expected before 2.18 and would work after #10436. But #10786 replaced fnc_isAwake with lifeState check so now #10436 would not help.

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.19.2 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** status/review-pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants