Skip to content

Explosives - Minor refactor #10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Explosives - Minor refactor #10805

wants to merge 7 commits into from

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Mar 15, 2025 •
edited
Loading

When merged this pull request will:

  • Code cleanup & optimisation.
  • Eliminate race condition for getting IED cellphone code.
  • Cache detonators.
  • Check variable types in public functions.
  • Remove ACE_Explosives_fnc_detonateExplosiveAll, as it's just a forEach loop.
  • Improve documentation.
  • Address ACE3 Feature Requests #3594 (comment) by adding ace_explosives_defuseStart and adding missing documentation for ace_explosives_defuse and ace_explosives_explodeOnDefuse.
  • Fully test all features.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

@rautamiekka rautamiekka rautamiekka requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @rautamiekka @PabstMirror