Skip to content

Refuel - Improved: Added Soundeffects #10825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Refuel - Improved: Added Soundeffects #10825

wants to merge 14 commits into from

Conversation

OverlordZorn
Copy link
Contributor

When merged this pull request will:

  • Adds Soundeffect to Refuel Start
  • Adds Soundeffect to Refuel Stopped

IMPORTANT

Requires CBATeam/CBA_A3#1751

@OverlordZorn
Copy link
Contributor Author

https://www.youtube.com/watch?v=cSatKnc3jSw

@BaerMitUmlaut
Copy link
Member

Did you record these yourself or are these licensed?

@OverlordZorn
Copy link
Contributor Author

Did you record these yourself or are these licensed?

they're from freesound.org, author and cc should be baked into the soundfile.

Stop:
https://freesound.org/people/joedeshon/sounds/117419/

You can copy, modify, distribute and perform the sound, even for commercial purposes, all without the need of asking permission to the author.

Start:
https://freesound.org/people/WryFighter/sounds/451551/

You are free to share (to copy, distribute and transmit) and to remix (to adapt and modify) as long as you credit the author of the sound.

@BaerMitUmlaut
Copy link
Member

Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds:

@OverlordZorn
Copy link
Contributor Author

Without an explicit license, these would fall under GPL (which would be wrong). Please follow the example of the fastroping sounds:

* https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/LICENSE#L30

* https://github.com/acemod/ACE3/blob/adb1199ee5cda958c834ec7635cab5cea5461724/addons/fastroping/data/sounds/LICENSE.md

will do - wasnt sure how else to do it!

@PabstMirror PabstMirror added target/next-cba kind/enhancement Release Notes: **IMPROVED:** labels Mar 27, 2025
@PabstMirror PabstMirror added this to the Ongoing milestone Mar 27, 2025
@BrettMayson
Copy link
Member

BrettMayson commented Apr 3, 2025 •
edited
Loading

I don't think it needs to go in authors, just license, unless I am wrong

@OverlordZorn
Copy link
Contributor Author

OverlordZorn commented Apr 3, 2025 •
edited
Loading

I don't think it needs to go in authors, just license, unless I am wrong

the fastroping sounds are in there, thats why i added them

ACE3/AUTHORS.txt

Line 182 in a82d5a4

Tessa Elieff <Fastroping Sound - CreativeCommons Attributions 3.0>

johnb432
johnb432 approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for next CBA release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-MF Mike-MF Mike-MF left review comments

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:** target/next-cba
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.
6 participants
@OverlordZorn @BaerMitUmlaut @BrettMayson @Mike-MF @johnb432 @PabstMirror