Skip to content

Repair - Patch to detect GM Wheel position and selection #10871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

lambdatiger
Copy link
Contributor

@lambdatiger lambdatiger commented Apr 18, 2025

When merged this pull request will:

  • Adds a method to ace_common_fnc_getWheelHitPointsWithSelections to find GM wheels and a selection that does not disappear when wheel damage is one / the wheel proxy goes away.
  • Adds a handle to skip normal GM wheel hitpoint selections and to add repair action to GM vehicles

Open to any feedback on how to make this less jank. I don't think anyone else uses proxies for wheels besides GM devs, so I only check for their work (they set a config flag on top of the DLC config entry).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the 3.20.0 milestone Apr 18, 2025
@PabstMirror PabstMirror merged commit bb6f885 into acemod:master Apr 25, 2025
3 checks passed
@lambdatiger lambdatiger deleted the gmWheelJank branch April 25, 2025 03:43
@johnb432 johnb432 linked an issue Apr 27, 2025 that may be closed by this pull request
@johnb432
Copy link
Contributor

johnb432 commented Apr 27, 2025

The motor cycle has scuffed wheel interaction points, but I'm assuming that it was already problematic before this PR. Good job, finding a solution to this problem was desperately needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GM Compatibility for replacing wheels
3 participants