Skip to content

Missile Defense - New Component#10965

Open
BrettMayson wants to merge 19 commits intoacemod:masterfrom
BrettMayson:missile_defense
Open

Missile Defense - New Component#10965
BrettMayson wants to merge 19 commits intoacemod:masterfrom
BrettMayson:missile_defense

Conversation

@BrettMayson
Copy link
Copy Markdown
Member

@BrettMayson BrettMayson commented Jun 17, 2025

When merged this pull request will:

https://www.youtube.com/watch?v=H-JSDWOMnXY

This meets my needs and if big changes are wanted someone will have to take over. I still didn't use a CBA state machine just because I wanted to do this quick and I don't know them.

Could maybe use some additional customization and functionality (specifying projectile classes to intercept, only fire on projectiles that will hit in a certain area?)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Copy Markdown
Contributor

@TheCandianVendingMachine TheCandianVendingMachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial pass, not super thorough. I'm going to close the other PR, I like this more in every way (especially naming given recent events...)

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Copy link
Copy Markdown
Contributor

@SpicyBagpipes SpicyBagpipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm daft and couldn't figure out how to PR the branch on GitHub desktop so have a review instead

Co-Authored-By: SpicyBagpipes <spicybagpipes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants