Skip to content

Migrate some EEG channel queries to typed database abstraction #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MaximeBICMTL wants to merge 4 commits into
base: bids_staging_branch
Choose a base branch
from
Open

Migrate some EEG channel queries to typed database abstraction #1361

MaximeBICMTL wants to merge 4 commits into from

Conversation

@MaximeBICMTL
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL commented Jan 10, 2026 •
edited
Loading

Builds on #1360 (which allows to use the env object in Eeg / Physiological).
Extracted from #1335.

Description

Migrate some physiological channel type / status type (or would "channel status type" be more correct ?) queries from the old database abstraction to the new typed database abstraction.

Details

  • Commit 1 fixes some physiological relationship declarations in the ORM models.
  • Commit 2 renames some ORM model fields to be more concise / descriptive.
  • Commit 3 adds the channel type / status type queries and uses them in Physiological.

@github-actions github-actions bot added the Language: Python Issue or PR related to the Python codebase label Jan 10, 2026
@MaximeBICMTL MaximeBICMTL added Category: Refactor Issue or PR that aims to improve the existing code Complexity: Simple Issue or PR that should be simple to implement, review, or test Pipeline: BIDS importer PR or issue related to the BIDS importer labels Jan 10, 2026
@MaximeBICMTL MaximeBICMTL changed the base branch from main to bids_staging_branch January 16, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffersoncasimir jeffersoncasimir Awaiting requested review from jeffersoncasimir

Assignees

No one assigned

Labels

Category: Refactor Issue or PR that aims to improve the existing code Complexity: Simple Issue or PR that should be simple to implement, review, or test Language: Python Issue or PR related to the Python codebase Pipeline: BIDS importer PR or issue related to the BIDS importer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MaximeBICMTL