BIDS events.tsv reader (LORIS BIDS reader PR 4) #1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language: Python
MaximeBICMTL
added
Complexity: Medium
MaximeBICMTL
force-pushed
the
loris_bids_reader_4_events_reader
branch
2 times, most recently
from
08f3dc2 to
d4a2605
Compare
MaximeBICMTL
force-pushed
the
loris_bids_reader_4_events_reader
branch
from
d4a2605 to
dd0c82d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1365 (diff)
Description
This PR adds two abstract
BidsTsvFile,BidsTsvRowclasses in the LORIS BIDS reader, as well as two specialized subclasses forBidsEventTsvRowandBidsEventsTsvFile, and adopts them in the BIDS EEG import pipeline. Having a specialized row class allows to move the validation logic out ofPhysiologicalinto the LORIS BIDS reader, which makes the code more isolated and re-usable.