Reorganize imaging_lib into mri module#1408
Open
MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
Open
Conversation
MaximeBICMTL
added
Category: Refactor
github-actions
bot
added
the
Language: Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before #1389, the
lib.mrimodule was used by the BIDS MRI importer, but that code has now been moved tolib.import_bids_dataset. As such, we can use thelib.mrimodule for pipeline-agnostic MRI-specific code.Changelog
lib.imaging_libtolib.mri.lib.imaging_lib.mri_scannertolib.mri.scanner.lib.imaging_lib.parametertolib.parameter(since it is not specific to MRI).Note that the
lib.imaging_libmodule does not exist in LORIS Python 27 was created in the LORIS Python 28/29 cycle. So this PR in itself is not a breaking change (but functions that were moved tolib.imaging_libduring that cycle are now moved tolib.mriinstead).