Skip to content

Typed DICOM archive validation - #1495

Draft
MaximeBICMTL wants to merge 1 commit into
aces:mainfrom
MaximeBICMTL:typed-dicom-archive-validation
Draft

Typed DICOM archive validation#1495
MaximeBICMTL wants to merge 1 commit into
aces:mainfrom
MaximeBICMTL:typed-dicom-archive-validation

Conversation

@MaximeBICMTL

@MaximeBICMTL MaximeBICMTL commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

**EDIT: Will rebase this PR after #1501 is merged **

Description

Refactor the validate-dicom-archive code to be strictly typed:

  • Use argparse instead of LorisGetOpt for CLI arguments parsing.
  • Refactor the code from using BasePipeline to a few typed functions.
  • Update the typing configuration in pyproject.toml by listing every untyped file of the DICOM to BIDS converter pipeline.
  • Update tests.

Breaking changes

The following validate-dicom-archive CLI options have been renamed:

  • --tarchive_path to --dicom-archive-path
  • --upload_id to --upload-id

@github-actions github-actions Bot added Language: Python Issue or PR related to the Python codebase Package: DICOM to BIDS converter PR or issue related to the DICOM to BIDS converter labels Aug 23, 2026
@MaximeBICMTL
MaximeBICMTL force-pushed the typed-dicom-archive-validation branch from 156ad55 to 4187385 Compare August 23, 2026 08:45
@MaximeBICMTL MaximeBICMTL added Caveat for Existing Projects Issue or PR that introduces or may introduce breaking changes for existing projects Category: Refactor Issue or PR that aims to improve the existing code Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test labels Aug 23, 2026
@MaximeBICMTL
MaximeBICMTL force-pushed the typed-dicom-archive-validation branch from 4187385 to 245b703 Compare August 23, 2026 09:51
@MaximeBICMTL
MaximeBICMTL requested a review from cmadjar August 24, 2026 11:42
@MaximeBICMTL
MaximeBICMTL marked this pull request as draft September 3, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmadjar cmadjar Awaiting requested review from cmadjar

Assignees

No one assigned

Labels

Category: Refactor Issue or PR that aims to improve the existing code Caveat for Existing Projects Issue or PR that introduces or may introduce breaking changes for existing projects Complexity: Medium Issue or PR that requires a moderate effort or expertise to implement, review, or test Language: Python Issue or PR related to the Python codebase Package: DICOM to BIDS converter PR or issue related to the DICOM to BIDS converter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MaximeBICMTL