Skip to content

[candidate parameters] Translates candidate parameters module. #10168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
racostas wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[candidate parameters] Translates candidate parameters module. #10168

racostas wants to merge 11 commits into from

Conversation

@racostas
Copy link
Contributor

@racostas racostas commented Nov 27, 2025 •
edited
Loading

  • Translates Candidate Parameters
  • Spanish language was use for demonstration purposes only.

Link(s) to related issue(s)

@racostas racostas added Module: candidate_parameters PR or issue related to candidate_parameters module Multilingual Any tasks related to making LORIS multilingual labels Nov 27, 2025
@github-actions github-actions bot added the Language: Javascript PR or issue that update Javascript code label Nov 27, 2025
@GeorgeMurad GeorgeMurad self-requested a review December 2, 2025 20:49
@GeorgeMurad
Copy link
Contributor

GeorgeMurad commented Dec 2, 2025

Shouldn't we translate the messages:
image

@GeorgeMurad
Copy link
Contributor

GeorgeMurad commented Dec 2, 2025

Similar here:
image
and here:
image

@racostas
Copy link
Contributor Author

racostas commented Dec 8, 2025

I translated the ones not coming for DB.

There are a few coming form DB in this module ( I think we're not translating this ones @driusan ? ):

image image

GeorgeMurad
GeorgeMurad approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

driusan
driusan reviewed Dec 11, 2025
View reviewed changes
driusan
driusan reviewed Dec 11, 2025
View reviewed changes
driusan
driusan reviewed Dec 11, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan left review comments

@GeorgeMurad GeorgeMurad GeorgeMurad approved these changes

Assignees

No one assigned

Labels

Language: Javascript PR or issue that update Javascript code Module: candidate_parameters PR or issue related to candidate_parameters module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[candidate_parameters] Multilingual Support

3 participants

@racostas @GeorgeMurad @driusan